chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc - Issue 900893003: Revert "Disable PopupBlockerBrowserTest.CtrlEnterKey"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

Issue 900893003: Revert "Disable PopupBlockerBrowserTest.CtrlEnterKey" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

diff --git a/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc b/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

index 0f2ee6d1c47be530c5b307dbfcf92d7a7b11bc3b..1ff40fe0157f5753d5bfb248bd9513be8c9f519e 100644

--- a/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

+++ b/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

@@ -624,8 +624,7 @@ void InjectRawKeyEvent(WebContents* web_contents,

}

// Tests that Ctrl+Enter/Cmd+Enter keys on a link open the backgournd tab.

-// Failing due to Blink r189541 http://crbug.com/455691

-IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, DISABLED_CtrlEnterKey) {

+IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, CtrlEnterKey) {

WebContents* tab = browser()->tab_strip_model()->GetActiveWebContents();

GURL url(embedded_test_server()->GetURL(

« no previous file with comments | « no previous file | no next file » | no next file with comments »