Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 900773003: Revert of Upgrade Blink to milliseconds-based last modified filetimes, part 3. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
Mike West, jsbell
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, jsbell, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@sof-fileinfo-modtime-in-ms-1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Upgrade Blink to milliseconds-based last modified filetimes, part 3. (patchset #4 id:60001 of https://codereview.chromium.org/884393002/) Reason for revert: Two linux32 failures coming through, http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=http/tests/local/fileapi/file-last-modified.html,storage/indexeddb/structured-clone.html Original issue's description: > Upgrade Blink to milliseconds-based last modified filetimes, part 3. > > With WebFileInfo now recording modification time in milliseconds via > modificationTimeMS, switch FileMetadata over to using it and keep a > milliseconds-based modification time field also. Also have the fileapi's > File object's snapshot times be milliseconds-based. > > To make it clearer what units the modification time values are over, > append a MS suffix. This is temporary until the conversion is complete. > > This patch is the third one in the following series, > > 1: [blink] add WebFileInfo::modificationTimeMS [ https://codereview.chromium.org/873723004/ ] > 2: [chromium] fill in modificationTimeMS [ https://codereview.chromium.org/884413002/ ] > 3: [blink] *this one* [ https://codereview.chromium.org/884393002/ ] > 4: [chromium] set modificationTime to something msec-based [ https://codereview.chromium.org/862203003/ ] > 5: [blink] switch to using modificationTime instead of *MS [ https://codereview.chromium.org/882343002/ ] > 6: [chromium] stop setting modificationTimeMS [ https://codereview.chromium.org/890523002/ ] > 7: [blink] remove modificationTimeMS [ https://codereview.chromium.org/869613005/ ] > > R=mkwst,jsbell > BUG=451747 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189475 TBR=mkwst@chromium.org,jsbell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=451747 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -86 lines) Patch
M LayoutTests/fast/storage/resources/serialized-script-value.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptValueSerializer.cpp View 6 chunks +9 lines, -16 lines 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/fileapi/File.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/fileapi/File.cpp View 12 chunks +30 lines, -30 lines 0 comments Download
M Source/core/html/FormDataList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FileInputTypeTest.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/filesystem/DOMFileSystemBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/FileSystemCallbacks.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/Metadata.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/FileMetadata.h View 2 chunks +6 lines, -12 lines 0 comments Download
M Source/platform/FileMetadata.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/exported/WebFileSystemCallbacks.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebFileChooserCompletionImpl.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M public/web/WebFileChooserCompletion.h View 1 chunk +2 lines, -2 lines 0 comments Download
M public/web/WebSerializedScriptValueVersion.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sof
Created Revert of Upgrade Blink to milliseconds-based last modified filetimes, part 3.
5 years, 10 months ago (2015-02-04 12:52:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900773003/1
5 years, 10 months ago (2015-02-04 12:53:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=189494
5 years, 10 months ago (2015-02-04 12:54:33 UTC) #3
Mike West
5 years, 10 months ago (2015-02-04 13:10:07 UTC) #4
Message was sent while issue was closed.
LGTM, thanks for reverting.

Powered by Google App Engine
This is Rietveld 408576698