Add namespace and re-arrange PDFium's local copy of chromium /base.

Add namespace and-re-arrange PDFium's local copy of chromium /base.

Any projects DEPS'd into chromium and requiring a /base
subset should have a local copy of that subset in a
separate namespace. This will avoid future naming conflicts.

Re-arrange the directory structure to better identify what
came from chromium's base, and to make drop-in replacement
easier for files that contain hard-coded "base/" in their
#include directives.

R=jam@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/dabc5d57bf473708295800a7991bc1fafdf76288

[Tom Sepez, 2015-02-04 20:15:51]

tsepez@chromium.org changed reviewers:
+ brettw@chromium.org

[Tom Sepez, 2015-02-04 20:17:33]

Hi Brett, please review.  I think this was in keeping with what you mentioned
the other day.  Thanks.

[Tom Sepez, 2015-02-04 20:20:19]

tsepez@chromium.org changed reviewers:
+ jam@chromium.org

[jam, 2015-02-04 23:16:42]

should the namespace be pdfium or third_party, i.e. to avoid clashes if other
projects do this?

https://codereview.chromium.org/900753002/diff/1/third_party/base/logging.h
File third_party/base/logging.h (right):

https://codereview.chromium.org/900753002/diff/1/third_party/base/logging.h#n...
third_party/base/logging.h:5: #ifndef BASE_LOGGING_H_
nit: this and others, update

[Lei Zhang, 2015-02-04 23:22:05]

On 2015/02/04 23:16:42, jam wrote:
> should the namespace be pdfium or third_party, i.e. to avoid clashes if other
> projects do this?
> 
> https://codereview.chromium.org/900753002/diff/1/third_party/base/logging.h
> File third_party/base/logging.h (right):
> 
>
https://codereview.chromium.org/900753002/diff/1/third_party/base/logging.h#n...
> third_party/base/logging.h:5: #ifndef BASE_LOGGING_H_
> nit: this and others, update

It probably should do avoid ODR violations.

[Tom Sepez, 2015-02-05 01:15:37]

> > should the namespace be pdfium or third_party, i.e. to avoid clashes if
other
> > projects do this?
Done.

> > third_party/base/logging.h:5: #ifndef BASE_LOGGING_H_
> > nit: this and others, update
Done.

[Tom Sepez, 2015-02-05 01:24:51]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org
- brettw@chromium.org

[jam, 2015-02-05 16:06:07]

lgtm

up to you, but I think just the pdfium namespace is sufficient, i.e. no need for
pdfium::base. That's just more typing, and pdfium is small enough that it
doesn't need nested namespaces.

[Tom Sepez, 2015-02-05 17:42:41]

On 2015/02/05 16:06:07, jam wrote:
> lgtm
> 
> up to you, but I think just the pdfium namespace is sufficient, i.e. no need
for
> pdfium::base. That's just more typing, and pdfium is small enough that it
> doesn't need nested namespaces.
Yeah, I was hoping to provide some sense to the reader that this is just a
familiar base:: type in different clothing, rather than a new pdfium type.

[Tom Sepez, 2015-02-05 17:46:29]

Committed patchset #3 (id:40001) manually as
dabc5d57bf473708295800a7991bc1fafdf76288 (presubmit successful).