Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 900733003: Update {virtual,override,final} to follow C++11 style. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, estade+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=pkasting@chromium.org Committed: https://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204 Cr-Commit-Position: refs/heads/master@{#314486}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -137 lines) Patch
M chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/android/autofill/autofill_popup_view_android.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/autofill/password_generation_popup_view_android.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.h View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/android/context_menu_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/confirm_infobar.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/infobars/generated_password_saved_infobar.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/android/infobars/infobar_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/infobar_container_android.h View 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/browser/ui/android/infobars/translate_infobar.h View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/android/javascript_app_modal_dialog_android.h View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/android/login_prompt_android.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.h View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/android/tab_model/tab_model_jni_bridge.h View 2 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/ui/android/tab_model/tab_model_list_unittest.cc View 1 chunk +10 lines, -11 lines 0 comments Download
M chrome/browser/ui/android/tab_model/tab_model_unittest.cc View 1 chunk +10 lines, -13 lines 0 comments Download
M chrome/browser/ui/android/toolbar/toolbar_model_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/website_settings_popup_android.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/android/website_settings_popup_legacy_android.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/android/window_android_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/auto_login_infobar_delegate.h View 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/auto_login_infobar_delegate.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/screen_capture_notification_ui_stub.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dcheng
5 years, 10 months ago (2015-02-04 00:48:41 UTC) #1
Peter Kasting
Rubber-stamp LGTM
5 years, 10 months ago (2015-02-04 00:59:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900733003/1
5 years, 10 months ago (2015-02-04 01:12:49 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/android/infobars/confirm_infobar.h: While running git apply --index -3 -p1; error: patch ...
5 years, 10 months ago (2015-02-04 01:50:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900733003/20001
5 years, 10 months ago (2015-02-04 02:08:40 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 02:56:40 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 02:58:42 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/361fdb39bdfcf68edd7df903103a399ea7a4f204
Cr-Commit-Position: refs/heads/master@{#314486}

Powered by Google App Engine
This is Rietveld 408576698