chrome/browser/ui/android/infobars/translate_infobar.h - Issue 900733003: Update {virtual,override,final} to follow C++11 style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/translate_infobar.h

Issue 900733003: Update {virtual,override,final} to follow C++11 style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/infobar_container_android.h ('k') | chrome/browser/ui/android/javascript_app_modal_dialog_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/translate_infobar.h

diff --git a/chrome/browser/ui/android/infobars/translate_infobar.h b/chrome/browser/ui/android/infobars/translate_infobar.h

index f03148c3112bb4ba39f6091ec3913bd02cccdc8c..e210a0ca84794b94cc0dfa0ba8a073884d5d4a1a 100644

--- a/chrome/browser/ui/android/infobars/translate_infobar.h

+++ b/chrome/browser/ui/android/infobars/translate_infobar.h

@@ -18,7 +18,7 @@ class TranslateInfoBar : public InfoBarAndroid {

public:

explicit TranslateInfoBar(

scoped_ptr<translate::TranslateInfoBarDelegate> delegate);

- virtual ~TranslateInfoBar();

+ ~TranslateInfoBar() override;

// JNI methods specific to translate.

void ApplyTranslateOptions(JNIEnv* env,

@@ -31,11 +31,10 @@ class TranslateInfoBar : public InfoBarAndroid {

private:

// InfoBarAndroid:

- virtual base::android::ScopedJavaLocalRef<jobject> CreateRenderInfoBar(

+ base::android::ScopedJavaLocalRef<jobject> CreateRenderInfoBar(

JNIEnv* env) override;

- virtual void ProcessButton(int action,

- const std::string& action_value) override;

- virtual void PassJavaInfoBar(InfoBarAndroid* source) override;

+ void ProcessButton(int action, const std::string& action_value) override;

+ void PassJavaInfoBar(InfoBarAndroid* source) override;

void TransferOwnership(TranslateInfoBar* destination,

translate::TranslateStep new_type);