Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 900613004: Update {virtual,override,final} to follow C++11 style in base. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in base. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Committed: https://crrev.com/8e3e03ecaadd10689ee34e65dce9d39cef123d65 Cr-Commit-Position: refs/heads/master@{#314951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -28 lines) Patch
M base/android/scoped_java_ref_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/android/trace_event_binding.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/memory/discardable_memory_ashmem.h View 1 chunk +8 lines, -8 lines 0 comments Download
M base/message_loop/message_pump_android.h View 1 chunk +5 lines, -5 lines 0 comments Download
M base/test/test_support_android.cc View 2 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 10 months ago (2015-02-06 01:02:15 UTC) #2
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-06 01:13:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900613004/1
5 years, 10 months ago (2015-02-06 01:14:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 03:32:50 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 03:33:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e3e03ecaadd10689ee34e65dce9d39cef123d65
Cr-Commit-Position: refs/heads/master@{#314951}

Powered by Google App Engine
This is Rietveld 408576698