Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3790)

Unified Diff: base/test/test_support_android.cc

Issue 900613004: Update {virtual,override,final} to follow C++11 style in base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop/message_pump_android.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/test_support_android.cc
diff --git a/base/test/test_support_android.cc b/base/test/test_support_android.cc
index eeab9eeefdc7ea73044976e92e91cbc299bd00cd..11a08715249b3fe97fe4a1a412df00512cd2c5b7 100644
--- a/base/test/test_support_android.cc
+++ b/base/test/test_support_android.cc
@@ -72,14 +72,14 @@ class Waitable {
// The MessagePumpForUI implementation for test purpose.
class MessagePumpForUIStub : public base::MessagePumpForUI {
- virtual ~MessagePumpForUIStub() {}
+ ~MessagePumpForUIStub() override {}
- virtual void Start(base::MessagePump::Delegate* delegate) override {
+ void Start(base::MessagePump::Delegate* delegate) override {
NOTREACHED() << "The Start() method shouldn't be called in test, using"
" Run() method should be used.";
}
- virtual void Run(base::MessagePump::Delegate* delegate) override {
+ void Run(base::MessagePump::Delegate* delegate) override {
// The following was based on message_pump_glib.cc, except we're using a
// WaitableEvent since there are no native message loop to use.
RunState state(delegate, g_state ? g_state->run_depth + 1 : 1);
@@ -119,16 +119,11 @@ class MessagePumpForUIStub : public base::MessagePumpForUI {
g_state = previous_state;
}
- virtual void Quit() override {
- Waitable::GetInstance()->Quit();
- }
+ void Quit() override { Waitable::GetInstance()->Quit(); }
- virtual void ScheduleWork() override {
- Waitable::GetInstance()->Signal();
- }
+ void ScheduleWork() override { Waitable::GetInstance()->Signal(); }
- virtual void ScheduleDelayedWork(
- const base::TimeTicks& delayed_work_time) override {
+ void ScheduleDelayedWork(const base::TimeTicks& delayed_work_time) override {
Waitable::GetInstance()->Signal();
}
};
« no previous file with comments | « base/message_loop/message_pump_android.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698