Mac: Make it easier for views to correctly draw with a theme.

chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.mm

Index: chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.mm b/chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.mm
index f4ef84d8aeaf655fd3e3779cf317a9e6909af95b..3034b38521f3727a0153f29bc213d5bda5ee5d87 100644
--- a/chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.mm
+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.mm
@@ -7,6 +7,7 @@
 #import "chrome/browser/ui/cocoa/themed_window.h"
 #import "chrome/browser/ui/cocoa/view_id_util.h"
 #import "ui/base/cocoa/nsgraphics_context_additions.h"
+#import "ui/base/cocoa/nsview_additions.h"
 
 @implementation ToolbarView
 
@@ -48,4 +49,11 @@
   return YES;
 }
 
+// ThemedWindowDrawing overrides.
+
+- (void)windowDidChangeActive {
+  // Need to redraw the omnibox and toolbar buttons as well.
+  [self cr_recursivelySetNeedsDisplay:YES];

[Andre, 2015/02/03 19:20:37]

This used to be done by BackgroundGradientView.

+}
+

[Avi (use Gerrit), 2015/02/03 21:53:34]

Don't you need -windowDidChangeTheme too? In BrowserWindowController, it checks
to see if the protocol was adopted, but not if the individual methods were
implemented.

[Andre, 2015/02/03 22:34:16]

-windowDidChangeTheme is a required method on a formal protocol, so we will get
a compiler warning if an implementation is missing. Therefore it should be safe
to not check for the individual methods at run time.
In this case, the BackgroundGradientView superclass provides an implementation
that we don't override.

 @end