Mac: Make it easier for views to correctly draw with a theme.

chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.h"
 
 #import "chrome/browser/ui/cocoa/themed_window.h"
 #import "chrome/browser/ui/cocoa/view_id_util.h"
 #import "ui/base/cocoa/nsgraphics_context_additions.h"
+#import "ui/base/cocoa/nsview_additions.h"
 
 @implementation ToolbarView
 
 @synthesize dividerOpacity = dividerOpacity_;
 
 // Prevent mouse down events from moving the parent window around.
 - (BOOL)mouseDownCanMoveWindow {
   return NO;
 }
 
@@ skipping 21 matching lines @@
 }
 
 - (ViewID)viewID {
   return VIEW_ID_TOOLBAR;
 }
 
 - (BOOL)isOpaque {
   return YES;
 }
 
+// ThemedWindowDrawing overrides.
+
+- (void)windowDidChangeActive {
+  // Need to redraw the omnibox and toolbar buttons as well.
+  [self cr_recursivelySetNeedsDisplay:YES];

[Andre, 2015/02/03 19:20:37]

This used to be done by BackgroundGradientView.

+}
+

[Avi (use Gerrit), 2015/02/03 21:53:34]

Don't you need -windowDidChangeTheme too? In BrowserWindowController, it checks
to see if the protocol was adopted, but not if the individual methods were
implemented.

[Andre, 2015/02/03 22:34:16]

-windowDidChangeTheme is a required method on a formal protocol, so we will get
a compiler warning if an implementation is missing. Therefore it should be safe
to not check for the individual methods at run time.
In this case, the BackgroundGradientView superclass provides an implementation
that we don't override.

 @end