Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1218)

Unified Diff: Source/core/inspector/DevToolsHost.h

Issue 900543003: DevTools: do not abuse inspector controller for the front-end side plumbing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/DevToolsHost.h
diff --git a/Source/core/inspector/DevToolsHost.h b/Source/core/inspector/DevToolsHost.h
index 79d0d43dbb4fe6975fbecc89bf42fcf35bbf20cb..d5356b76b814655497c7ad7a775897d0f566e55e 100644
--- a/Source/core/inspector/DevToolsHost.h
+++ b/Source/core/inspector/DevToolsHost.h
@@ -40,14 +40,14 @@ class ContextMenuItem;
class Event;
class FrontendMenuProvider;
class InspectorFrontendClient;
-class Page;
+class LocalFrame;
class DevToolsHost : public RefCountedWillBeGarbageCollectedFinalized<DevToolsHost>, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
- static PassRefPtrWillBeRawPtr<DevToolsHost> create(InspectorFrontendClient* client, Page* frontendPage)
+ static PassRefPtrWillBeRawPtr<DevToolsHost> create(InspectorFrontendClient* client, LocalFrame* frontendFrame)
{
- return adoptRefWillBeNoop(new DevToolsHost(client, frontendPage));
+ return adoptRefWillBeNoop(new DevToolsHost(client, frontendFrame));
}
~DevToolsHost();
@@ -62,7 +62,7 @@ public:
// Called from [Custom] implementations.
void showContextMenu(Event*, const Vector<ContextMenuItem>& items);
- void showContextMenu(Page*, float x, float y, const Vector<ContextMenuItem>& items);
+ void showContextMenu(float x, float y, const Vector<ContextMenuItem>& items);
void sendMessageToBackend(const String& message);
void sendMessageToEmbedder(const String& message);
@@ -72,15 +72,15 @@ public:
bool isUnderTest();
bool isHostedMode();
- Page* frontendPage() { return m_frontendPage; }
+ LocalFrame* frontendFrame() { return m_frontendFrame; }
void clearMenuProvider() { m_menuProvider = nullptr; }
private:
- DevToolsHost(InspectorFrontendClient*, Page* frontendPage);
+ DevToolsHost(InspectorFrontendClient*, LocalFrame* frontendFrame);
InspectorFrontendClient* m_client;
- RawPtrWillBeMember<Page> m_frontendPage;
+ RawPtrWillBeMember<LocalFrame> m_frontendFrame;
RawPtrWillBeMember<FrontendMenuProvider> m_menuProvider;
};

Powered by Google App Engine
This is Rietveld 408576698