Mark RemoteHostAccessRequireTwoFactor as deprecated.

Mark RemoteHostAccessRequireTwoFactor as deprecated.

BUG=455900
Committed: https://crrev.com/b6e4a35cdf43d63f35dcced2bb766205955c1501
Cr-Commit-Position: refs/heads/master@{#315343}

[Łukasz Anforowicz, 2015-02-05 23:47:38]

lukasza@chromium.org changed reviewers:
+ bartfab@chromium.org

[Łukasz Anforowicz, 2015-02-05 23:47:39]

Bart - could you please take a look?  In a design review meeting today, we
reviewed all Chromoting policies and found out that one of them is declared in
policy_templates.json but not used anywhere in the code.  We therefore want to
mark this policy as deprecated.

[bartfab (slow), 2015-02-06 14:18:18]

https://codereview.chromium.org/900363003/diff/1/components/policy/resources/...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/900363003/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:568: 'supported_on':
['chrome.*:14-16'],  # Removed by https://codereview.chromium.org/8275012.
1) The "chrome.*:14-16" part LGTM.
2) I would prefer to not add any inline comments here though. We have a number
of deprecated policies and we do not tend to include links to the CLs that
deprecated them.
3) What happened to "chrome_os:14-"? Why did it just disappear?

https://codereview.chromium.org/900363003/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:626: 'supported_on':
['chrome.*:22-22'],  # Declared, but never used by crrev.com/10825149.
As above.

https://codereview.chromium.org/900363003/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:631: 'deprecated': True,
Please add the following above this line:

# Mark this 'removed' when http://crbug.com/100216 is resolved.

[Łukasz Anforowicz, 2015-02-06 20:29:09]

New patchsets have been uploaded after l-g-t-m from bartfab@chromium.org

[Łukasz Anforowicz, 2015-02-06 20:29:20]

Thanks Bart.  Could you please take another look?

https://codereview.chromium.org/900363003/diff/1/components/policy/resources/...
File components/policy/resources/policy_templates.json (left):

https://codereview.chromium.org/900363003/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:626: 'supported_on':
['chrome.*:22-', 'chrome_os:41-'],
This is a host-side policy - it wasn't handled when it2me host support was being
added to ChromeOS in 41.  Therefore chrome_os annotation should be removed here
(this annotation was added in the current/42 release cycle - in
https://codereview.chromium.org/820133002/).

https://codereview.chromium.org/900363003/diff/1/components/policy/resources/...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/900363003/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:568: 'supported_on':
['chrome.*:14-16'],  # Removed by https://codereview.chromium.org/8275012.
On 2015/02/06 14:18:18, bartfab wrote:
> 1) The "chrome.*:14-16" part LGTM.
Ack.

> 2) I would prefer to not add any inline comments here though. We have a number
> of deprecated policies and we do not tend to include links to the CLs that
> deprecated them.

Done.

> 3) What happened to "chrome_os:14-"? Why did it just disappear?

Thanks for catching this.  I incorrectly removed this thinking that all
Chromoting policies were added much later to ChromeOS - in 41 (when it2me host
support was being added), but this is incorrect for a client-side policy like
the one here.

https://codereview.chromium.org/900363003/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:626: 'supported_on':
['chrome.*:22-22'],  # Declared, but never used by crrev.com/10825149.
On 2015/02/06 14:18:18, bartfab wrote:
> As above.

Done.

https://codereview.chromium.org/900363003/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:631: 'deprecated': True,
On 2015/02/06 14:18:18, bartfab wrote:
> Please add the following above this line:
> 
> # Mark this 'removed' when http://crbug.com/100216 is resolved.

Done.

[bartfab (slow), 2015-02-09 08:28:06]

lgtm

https://codereview.chromium.org/900363003/diff/20001/components/policy/resour...
File components/policy/resources/policy_templates.json (left):

https://codereview.chromium.org/900363003/diff/20001/components/policy/resour...
components/policy/resources/policy_templates.json:626: 'supported_on':
['chrome.*:22-', 'chrome_os:41-'],
It's a bit unfortunate that we documented this as supported on Chrome OS 41 but
then later realized it had actually been removed from the code base in M22...
but alas, so be it - let's remove any mention of Chrome OS from this policy.

[Łukasz Anforowicz, 2015-02-09 17:21:02]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2015-02-09 17:22:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900363003/20001

[commit-bot: I haz the power, 2015-02-09 18:13:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-09 18:15:11]

Patchset 2 (id:??) landed as
https://crrev.com/b6e4a35cdf43d63f35dcced2bb766205955c1501
Cr-Commit-Position: refs/heads/master@{#315343}