Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 8275012: Remove RemoteAccessClientFirewallTraversal policy and code paths. (Closed)

Created:
9 years, 2 months ago by Wez
Modified:
9 years, 2 months ago
CC:
chromium-reviews, John Grabowski, dpranke+watch-content_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, anantha, darin-cc_chromium.org, brettw-cc_chromium.org, dennis_jeffrey, Avi (use Gerrit), dmaclach+watch_chromium.org, creis+watch_chromium.org, wez+watch_chromium.org, simonmorris+watch_chromium.org, piman+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, Nirnimesh, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, dyu1, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove RemoteAccessClientFirewallTraversal policy and code paths. BUG=96318 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106521

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase across MouseLock move. #

Patch Set 4 : Rebase, rinse, repeat. #

Patch Set 5 : Re-rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -735 lines) Patch
M chrome/app/policy/policy_templates.json View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store_unittest.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/remoting/firewall_traversal_observer.h View 1 2 3 4 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/remoting/firewall_traversal_observer.cc View 1 2 3 4 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/browser/remoting/firewall_traversal_observer_unittest.cc View 1 2 3 4 1 chunk +0 lines, -51 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.h View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/functional/policy_prefs_ui.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/ui/ppapi_uitest.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 4 2 chunks +0 lines, -12 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.h View 1 2 3 4 4 chunks +0 lines, -11 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 1 2 3 4 5 chunks +0 lines, -24 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 3 chunks +0 lines, -11 lines 0 comments Download
D ppapi/api/dev/ppb_query_policy_dev.idl View 1 chunk +0 lines, -26 lines 0 comments Download
D ppapi/api/dev/ppp_policy_update_dev.idl View 1 chunk +0 lines, -27 lines 0 comments Download
D ppapi/c/dev/ppb_query_policy_dev.h View 1 chunk +0 lines, -47 lines 0 comments Download
D ppapi/c/dev/ppp_policy_update_dev.h View 1 chunk +0 lines, -47 lines 0 comments Download
M ppapi/ppapi_cpp.gypi View 1 2 3 4 2 chunks +0 lines, -3 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/ppapi_tests.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M ppapi/tests/all_c_includes.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
D ppapi/tests/test_query_policy.h View 1 chunk +0 lines, -30 lines 0 comments Download
D ppapi/tests/test_query_policy.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_instance_api.h View 1 chunk +0 lines, -3 lines 0 comments Download
D ppapi/thunk/ppb_query_policy_thunk.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M ppapi/thunk/thunk.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.h View 3 chunks +0 lines, -19 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 2 7 chunks +1 line, -105 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 2 chunks +0 lines, -10 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 5 chunks +0 lines, -5 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 6 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Wez
This CL removes the RemoteAccessClientFirewallTraversal policy, the associated code to propagate policy into renderers, and ...
9 years, 2 months ago (2011-10-13 19:53:08 UTC) #1
awong
LGTM
9 years, 2 months ago (2011-10-13 20:00:11 UTC) #2
Mattias Nissler (ping if slow)
chrome/browser/policy LGTM FYI: We're planning to add policy support for browser add-ons during Q4, initially ...
9 years, 2 months ago (2011-10-13 20:55:26 UTC) #3
Mattias Nissler (ping if slow)
chrome/browser/prefs LGTM too.
9 years, 2 months ago (2011-10-13 20:56:04 UTC) #4
Wez
jam: FYI (and feel free to review in place of ananta@ ;)
9 years, 2 months ago (2011-10-13 22:18:53 UTC) #5
ananta
On 2011/10/13 22:18:53, Wez wrote: > jam: FYI (and feel free to review in place ...
9 years, 2 months ago (2011-10-14 00:45:26 UTC) #6
jam
content lgtm, thanks
9 years, 2 months ago (2011-10-14 16:58:02 UTC) #7
Wez
dmichael: Please review ppapi/...
9 years, 2 months ago (2011-10-14 22:02:06 UTC) #8
Wez
piman: dmichael seems busy/absent. Would you do the honours?
9 years, 2 months ago (2011-10-18 22:44:05 UTC) #9
piman
9 years, 2 months ago (2011-10-18 22:46:01 UTC) #10
PPAPI LGTM

Powered by Google App Engine
This is Rietveld 408576698