Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 900053002: Minor robustness improvements for VTVideoDecodeAccelerator. (Closed)

Created:
5 years, 10 months ago by sandersd (OOO until July 31)
Modified:
5 years, 10 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor robustness improvements for VTVideoDecodeAccelerator. - Fail if VideoToolbox returns a null pointer, instead of crashing. - Stop processing as soon as an error occurs. BUG=453050 Committed: https://crrev.com/e01484c024a19127571536dce4a5ab89ddbc9850 Cr-Commit-Position: refs/heads/master@{#314682}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M content/common/gpu/media/vt_video_decode_accelerator.cc View 1 2 chunks +22 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sandersd (OOO until July 31)
5 years, 10 months ago (2015-02-04 22:33:26 UTC) #2
DaleCurtis
lgtm % a comment https://codereview.chromium.org/900053002/diff/1/content/common/gpu/media/vt_video_decode_accelerator.cc File content/common/gpu/media/vt_video_decode_accelerator.cc (right): https://codereview.chromium.org/900053002/diff/1/content/common/gpu/media/vt_video_decode_accelerator.cc#newcode635 content/common/gpu/media/vt_video_decode_accelerator.cc:635: } else if (!image_buffer || ...
5 years, 10 months ago (2015-02-04 22:38:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900053002/20001
5 years, 10 months ago (2015-02-04 22:54:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 00:01:41 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 00:02:25 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e01484c024a19127571536dce4a5ab89ddbc9850
Cr-Commit-Position: refs/heads/master@{#314682}

Powered by Google App Engine
This is Rietveld 408576698