Modify rasterize_and_record for DisplayItemList recording.

Modify rasterize_and_record for DisplayItemList recording.

There is a lot of change here for relatively little effect.
That effect is important, however, for moving forward.

This depends on https://codereview.chromium.org/880653004/.

1) Move Picture::RecordingMode to RecordingSource, because
   Display List recording does not use Picture.
2) Add a new recording mode for disabled caches, which has
   meaning in Display List recording. Picture recording falls
   back to normal recording, while Display List recording
   uses painting disabled mode when null canvas is specified,
   because null canvas has no meaning for Display Lists.
3) Rename the enum in ContentLayerClient to reflect the new
   painting control modes and the changes in
   WebContentLayerClient.
4) Adjust all the code that uses these settings.
5) Adjust the benchmark code to make use of the new modes.

R=ajuma,vmpstr
BUG=451448
Committed: https://crrev.com/0154bfa2bd8c5cd8a906deb1e6415f7c7fc417a0
Cr-Commit-Position: refs/heads/master@{#314857}

[Stephen Chennney, 2015-02-04 22:25:20]

Can't land yet. Let me know what you think.

[ajuma, 2015-02-04 22:47:34]

This seems reasonable to me.

https://codereview.chromium.org/900043002/diff/1/cc/blink/web_content_layer_i...
File cc/blink/web_content_layer_impl.cc (right):

https://codereview.chromium.org/900043002/diff/1/cc/blink/web_content_layer_i...
cc/blink/web_content_layer_impl.cc:23: PaintingControlToWeb(
This should either be static or inside an anonymous namespace.

https://codereview.chromium.org/900043002/diff/1/cc/resources/display_list_re...
File cc/resources/display_list_recording_source.cc (right):

https://codereview.chromium.org/900043002/diff/1/cc/resources/display_list_re...
cc/resources/display_list_recording_source.cc:105: // With Blink caching
recordings, repeated calls will not cause re-recording.
This TODO can be removed now that we're choosing whether to cache.

[Stephen Chennney, 2015-02-05 14:57:42]

Thanks. Updated.

https://codereview.chromium.org/900043002/diff/1/cc/blink/web_content_layer_i...
File cc/blink/web_content_layer_impl.cc (right):

https://codereview.chromium.org/900043002/diff/1/cc/blink/web_content_layer_i...
cc/blink/web_content_layer_impl.cc:23: PaintingControlToWeb(
On 2015/02/04 22:47:33, ajuma wrote:
> This should either be static or inside an anonymous namespace.

Made static.

https://codereview.chromium.org/900043002/diff/1/cc/resources/display_list_re...
File cc/resources/display_list_recording_source.cc (right):

https://codereview.chromium.org/900043002/diff/1/cc/resources/display_list_re...
cc/resources/display_list_recording_source.cc:105: // With Blink caching
recordings, repeated calls will not cause re-recording.
On 2015/02/04 22:47:33, ajuma wrote:
> This TODO can be removed now that we're choosing whether to cache.

I reworked the logic to force non-caching if the repeat count is greater than 1.

[Stephen Chennney, 2015-02-05 15:04:25]

The Blink side changes have also landed now, so it can be committed once we're
all satisfied.

[Stephen Chennney, 2015-02-05 15:06:18]

schenney@chromium.org changed reviewers:
+ nduca@chromium.org, skyostil@chromium.org, vollick@chromium.org

[Stephen Chennney, 2015-02-05 15:06:46]

And added reviewers to hit all the different ownership requirements.

[ajuma, 2015-02-05 15:08:34]

On 2015/02/05 14:57:42, Stephen Chenney wrote:
> Thanks. Updated.
> 
>
https://codereview.chromium.org/900043002/diff/1/cc/blink/web_content_layer_i...
> File cc/blink/web_content_layer_impl.cc (right):
> 
>
https://codereview.chromium.org/900043002/diff/1/cc/blink/web_content_layer_i...
> cc/blink/web_content_layer_impl.cc:23: PaintingControlToWeb(
> On 2015/02/04 22:47:33, ajuma wrote:
> > This should either be static or inside an anonymous namespace.
> 
> Made static.
> 
>
https://codereview.chromium.org/900043002/diff/1/cc/resources/display_list_re...
> File cc/resources/display_list_recording_source.cc (right):
> 
>
https://codereview.chromium.org/900043002/diff/1/cc/resources/display_list_re...
> cc/resources/display_list_recording_source.cc:105: // With Blink caching
> recordings, repeated calls will not cause re-recording.
> On 2015/02/04 22:47:33, ajuma wrote:
> > This TODO can be removed now that we're choosing whether to cache.
> 
> I reworked the logic to force non-caching if the repeat count is greater than
1.

lgtm

[nduca, 2015-02-05 17:51:43]

lgtm

[Stephen Chennney, 2015-02-05 17:56:58]

schenney@chromium.org changed reviewers:
+ danakj@chromium.org
- vollick@chromium.org

[danakj, 2015-02-05 17:59:25]

ui/ lgtm

[Stephen Chennney, 2015-02-05 18:00:23]

The CQ bit was checked by schenney@chromium.org

[commit-bot: I haz the power, 2015-02-05 18:01:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900043002/20001

[commit-bot: I haz the power, 2015-02-05 18:21:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-05 18:21:45]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Stephen Chennney, 2015-02-05 18:43:26]

New patchsets have been uploaded after l-g-t-m from
ajuma@chromium.org,nduca@chromium.org,danakj@chromium.org

[Stephen Chennney, 2015-02-05 18:43:41]

The CQ bit was checked by schenney@chromium.org

[commit-bot: I haz the power, 2015-02-05 18:44:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900043002/40001

[commit-bot: I haz the power, 2015-02-05 19:47:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-05 19:48:15]

Patchset 3 (id:??) landed as
https://crrev.com/0154bfa2bd8c5cd8a906deb1e6415f7c7fc417a0
Cr-Commit-Position: refs/heads/master@{#314857}