Modify rasterize_and_record for DisplayItemList recording.

cc/resources/display_list_recording_source.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/display_list_recording_source.h"
 
 #include <algorithm>
 
 #include "cc/base/region.h"
 #include "cc/layers/content_layer_client.h"
@@ skipping 27 matching lines @@
 DisplayListRecordingSource::~DisplayListRecordingSource() {
 }
 
 bool DisplayListRecordingSource::UpdateAndExpandInvalidation(
     ContentLayerClient* painter,
     Region* invalidation,
     bool can_use_lcd_text,
     const gfx::Size& layer_size,
     const gfx::Rect& visible_layer_rect,
     int frame_number,
-    Picture::RecordingMode recording_mode) {
+    RecordingMode recording_mode) {
   bool updated = false;
 
   if (size_ != layer_size) {
     size_ = layer_size;
     updated = true;
   }
 
   if (can_use_lcd_text_ != can_use_lcd_text) {
     can_use_lcd_text_ = can_use_lcd_text;
     invalidation->Union(gfx::Rect(GetSize()));
@@ skipping 15 matching lines @@
     Region no_longer_exposed_region(old_recorded_viewport);
     no_longer_exposed_region.Subtract(recorded_viewport_);
     invalidation->Union(no_longer_exposed_region);
 
     updated = true;
   }
 
   if (!updated && !invalidation->Intersects(recorded_viewport_))
     return false;
 
-  // TODO(ajuma): Does repeating this way really makes sense with display lists?
+  ContentLayerClient::PaintingControlSetting painting_control =
+      ContentLayerClient::PAINTING_BEHAVIOR_NORMAL;
+
+  switch (recording_mode) {
+    case RECORD_NORMALLY:
+      // Already setup for normal recording.
+      break;
+    case RECORD_WITH_SK_NULL_CANVAS:
+    // TODO(schenney): Remove this when DisplayList recording is the only
+    // option. For now, fall through and disable construction.
+    case RECORD_WITH_PAINTING_DISABLED:
+      painting_control = ContentLayerClient::DISPLAY_LIST_CONSTRUCTION_DISABLED;
+      break;
+    case RECORD_WITH_CACHING_DISABLED:
+      painting_control = ContentLayerClient::DISPLAY_LIST_CACHING_DISABLED;
+      break;
+    default:
+      NOTREACHED();
+  }
+
+  // TODO(ajuma): Does repeating this way really make sense with display lists?
   // With Blink caching recordings, repeated calls will not cause re-recording.

[ajuma, 2015/02/04 22:47:33]

This TODO can be removed now that we're choosing whether to cache.

[Stephen Chennney, 2015/02/05 14:57:42]

I reworked the logic to force non-caching if the repeat count is greater than 1.

   int repeat_count = std::max(1, slow_down_raster_scale_factor_for_debug_);
   for (int i = 0; i < repeat_count; ++i) {
-    display_list_ = painter->PaintContentsToDisplayList(
-        recorded_viewport_, ContentLayerClient::GRAPHICS_CONTEXT_ENABLED);
+    display_list_ = painter->PaintContentsToDisplayList(recorded_viewport_,
+                                                        painting_control);
   }
   display_list_->set_layer_rect(recorded_viewport_);
   is_suitable_for_gpu_rasterization_ =
       display_list_->IsSuitableForGpuRasterization();
 
   DetermineIfSolidColor();
   display_list_->EmitTraceSnapshot();
   return true;
 }
 
@@ skipping 42 matching lines @@
   is_solid_color_ = canvas.GetColorIfSolid(&solid_color_);
 }
 
 void DisplayListRecordingSource::Clear() {
   recorded_viewport_ = gfx::Rect();
   display_list_ = NULL;
   is_solid_color_ = false;
 }
 
 }  // namespace cc