Chromium Code Reviews Chromium Code Reviews
Issue
899853002:
Merge 188868 "Revert of Make SpeechRecognitionController per fra..." (Closed)
DescriptionMerge 188868 "Revert of Make SpeechRecognitionController per fra..."
> Revert of Make SpeechRecognitionController per frame instead of per page. (patchset #3 id:40001 of https://codereview.chromium.org/636863002/)
>
> Reason for revert:
> https://crbug.com/449739
>
> Original issue's description:
> > Make SpeechRecognitionController per frame instead of per page.
> >
> > This is still using the WebViewClient::speechRecognizer() if
> > WebFrameClient::speechRecognizer() returns null. After part 2
> > lands, part 3 will remove it.
> >
> > Part 1: <this>
> > Part 2: https://codereview.chromium.org/636863003/
> > Part 3: https://codereview.chromium.org/752303003/
> >
> > BUG=390749
> >
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186174
>
> TBR=dcheng@chromium.org,mkwst@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=390749, 449739
>
> Review URL: https://codereview.chromium.org/863213002
TBR=mlamouri@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189483
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
