Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 863213002: Revert of Make SpeechRecognitionController per frame instead of per page. (Closed)

Created:
5 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 11 months ago
Reviewers:
Mike West, dcheng
CC:
blink-reviews, dglazkov+blink, jamesr, mkwst+moarreviews_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Make SpeechRecognitionController per frame instead of per page. (patchset #3 id:40001 of https://codereview.chromium.org/636863002/) Reason for revert: https://crbug.com/449739 Original issue's description: > Make SpeechRecognitionController per frame instead of per page. > > This is still using the WebViewClient::speechRecognizer() if > WebFrameClient::speechRecognizer() returns null. After part 2 > lands, part 3 will remove it. > > Part 1: <this> > Part 2: https://codereview.chromium.org/636863003/ > Part 3: https://codereview.chromium.org/752303003/ > > BUG=390749 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186174 TBR=dcheng@chromium.org,mkwst@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=390749, 449739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188868

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -37 lines) Patch
M Source/modules/speech/SpeechRecognition.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionController.h View 1 2 chunks +4 lines, -6 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionController.cpp View 1 2 chunks +7 lines, -13 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 4 chunks +0 lines, -8 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M public/web/WebFrameClient.h View 1 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mlamouri (slow - plz ping)
Created Revert of Make SpeechRecognitionController per frame instead of per page.
5 years, 11 months ago (2015-01-22 10:39:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863213002/1
5 years, 11 months ago (2015-01-22 10:40:16 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/web/WebLocalFrameImpl.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 11 months ago (2015-01-22 10:40:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863213002/180001
5 years, 11 months ago (2015-01-23 09:35:12 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 09:35:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:180001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188868

Powered by Google App Engine
This is Rietveld 408576698