Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 899803003: Removed most of the bogus CompilationInfo constructor calls. (Closed)

Created:
5 years, 10 months ago by Sven Panne
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Removed most of the bogus CompilationInfo constructor calls. A CompilationInfo constructed from just an Isolate* and a Zone* is in weird an inconsistent state (calling e.g. flags() on it will crash), so we need to avoid them. This CL removes almost all of them, the remaining 2 call sites in (for testing only) will be handled in a separate CL. Things which have been changed: * Linkage is basically a decorator for CallDescriptor now. * ChangeLowering doesn't need Linkage at all. * JSGenericLowering doesn't need a full CompilationInfo*, just a single flag. * JSContextSpecializer doesn't need the full CompilationInfo, just a Context. * Removed unused CompilationInfo from SimplifiedLoweringTester. This nicely decouples things already a bit more, but there's still work to do... Committed: https://crrev.com/d1b5aa0716752e328102fb7b0780d750c08a3673 Cr-Commit-Position: refs/heads/master@{#26580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -115 lines) Patch
M src/compiler/change-lowering.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/compiler/change-lowering.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/js-context-specialization.h View 3 chunks +5 lines, -3 lines 0 comments Download
M src/compiler/js-context-specialization.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M src/compiler/js-generic-lowering.h View 2 chunks +3 lines, -6 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 10 chunks +21 lines, -20 lines 0 comments Download
M src/compiler/linkage.h View 2 chunks +2 lines, -18 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/compiler/pipeline.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 5 chunks +4 lines, -8 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +1 line, -5 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 10 months ago (2015-02-11 13:37:45 UTC) #2
dcarney
lgtm
5 years, 10 months ago (2015-02-11 13:41:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899803003/1
5 years, 10 months ago (2015-02-11 13:43:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 14:12:08 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 14:12:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1b5aa0716752e328102fb7b0780d750c08a3673
Cr-Commit-Position: refs/heads/master@{#26580}

Powered by Google App Engine
This is Rietveld 408576698