Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4910)

Unified Diff: chrome/browser/ui/browser_window.h

Issue 899443002: Create bookmark apps at the end of the process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index d4e6aa800eddbbb2777e41836740658a14c3e149..13a0dabb8ad20d686f1e11bf024565bcb137ab7a 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -221,14 +221,20 @@ class BrowserWindow : public ui::BaseWindow {
// |already_bookmarked| is true if the url is already bookmarked.
virtual void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) = 0;
+ // Callback type used with the ShowBookmarkAppBubble() method. The boolean
+ // parameter is true when the user accepts the dialog. The WebApplicationInfo
+ // parameter contains the WebApplicationInfo as edited by the user.
+ typedef base::Callback<void(bool, const WebApplicationInfo&)>
+ ShowBookmarkAppBubbleCallback;
+
// Shows the Bookmark App bubble.
// See Extension::InitFromValueFlags::FROM_BOOKMARK for a description of
// bookmark apps.
//
// |web_app_info| is the WebApplicationInfo being converted into an app.
- // |extension_id| is the id of the bookmark app.
- virtual void ShowBookmarkAppBubble(const WebApplicationInfo& web_app_info,
- const std::string& extension_id) = 0;
+ virtual void ShowBookmarkAppBubble(
+ const WebApplicationInfo& web_app_info,
+ const ShowBookmarkAppBubbleCallback& callback) = 0;
// Shows the translate bubble.
//

Powered by Google App Engine
This is Rietveld 408576698