Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/browser/ui/browser_window.h

Issue 899443002: Create bookmark apps at the end of the process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
7 7
8 #include "base/callback_forward.h" 8 #include "base/callback_forward.h"
9 #include "chrome/browser/lifetime/browser_close_manager.h" 9 #include "chrome/browser/lifetime/browser_close_manager.h"
10 #include "chrome/browser/signin/signin_header_helper.h" 10 #include "chrome/browser/signin/signin_header_helper.h"
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 virtual void ConfirmAddSearchProvider(TemplateURL* template_url, 214 virtual void ConfirmAddSearchProvider(TemplateURL* template_url,
215 Profile* profile) = 0; 215 Profile* profile) = 0;
216 216
217 // Shows the Update Recommended dialog box. 217 // Shows the Update Recommended dialog box.
218 virtual void ShowUpdateChromeDialog() = 0; 218 virtual void ShowUpdateChromeDialog() = 0;
219 219
220 // Shows the Bookmark bubble. |url| is the URL being bookmarked, 220 // Shows the Bookmark bubble. |url| is the URL being bookmarked,
221 // |already_bookmarked| is true if the url is already bookmarked. 221 // |already_bookmarked| is true if the url is already bookmarked.
222 virtual void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) = 0; 222 virtual void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) = 0;
223 223
224 // Callback type used with the ShowBookmarkAppBubble() method. The boolean
225 // parameter is true when the user accepts the dialog. The WebApplicationInfo
226 // parameter contains the WebApplicationInfo as edited by the user.
227 typedef base::Callback<void(bool, const WebApplicationInfo&)>
228 ShowBookmarkAppBubbleCallback;
229
224 // Shows the Bookmark App bubble. 230 // Shows the Bookmark App bubble.
225 // See Extension::InitFromValueFlags::FROM_BOOKMARK for a description of 231 // See Extension::InitFromValueFlags::FROM_BOOKMARK for a description of
226 // bookmark apps. 232 // bookmark apps.
227 // 233 //
228 // |web_app_info| is the WebApplicationInfo being converted into an app. 234 // |web_app_info| is the WebApplicationInfo being converted into an app.
229 // |extension_id| is the id of the bookmark app. 235 virtual void ShowBookmarkAppBubble(
230 virtual void ShowBookmarkAppBubble(const WebApplicationInfo& web_app_info, 236 const WebApplicationInfo& web_app_info,
231 const std::string& extension_id) = 0; 237 const ShowBookmarkAppBubbleCallback& callback) = 0;
232 238
233 // Shows the translate bubble. 239 // Shows the translate bubble.
234 // 240 //
235 // |is_user_gesture| is true when the bubble is shown on the user's deliberate 241 // |is_user_gesture| is true when the bubble is shown on the user's deliberate
236 // action. 242 // action.
237 virtual void ShowTranslateBubble( 243 virtual void ShowTranslateBubble(
238 content::WebContents* contents, 244 content::WebContents* contents,
239 translate::TranslateStep step, 245 translate::TranslateStep step,
240 translate::TranslateErrors::Type error_type, 246 translate::TranslateErrors::Type error_type,
241 bool is_user_gesture) = 0; 247 bool is_user_gesture) = 0;
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 virtual void ExecuteExtensionCommand(const extensions::Extension* extension, 394 virtual void ExecuteExtensionCommand(const extensions::Extension* extension,
389 const extensions::Command& command) = 0; 395 const extensions::Command& command) = 0;
390 396
391 protected: 397 protected:
392 friend class BrowserCloseManager; 398 friend class BrowserCloseManager;
393 friend class BrowserView; 399 friend class BrowserView;
394 virtual void DestroyBrowser() = 0; 400 virtual void DestroyBrowser() = 0;
395 }; 401 };
396 402
397 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 403 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698