Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 89943002: Have DOMWindow name getter / setter deal with AtomicStrings (Closed)

Created:
7 years ago by Inactive
Modified:
7 years ago
CC:
blink-reviews
Visibility:
Public.

Description

Have DOMWindow name getter / setter deal with AtomicStrings Have DOMWindow name getter / setter deal with AtomicStrings instead of Strings. We use an AtomicString for the window name internally so this avoids constructing a String uselessly and then converting it to an AtomicString. R=abarth BUG=323739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162746

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/core/frame/DOMWindow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 chunk +5 lines, -5 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
https://codereview.chromium.org/89943002/diff/1/Source/core/frame/DOMWindow.cpp File Source/core/frame/DOMWindow.cpp (right): https://codereview.chromium.org/89943002/diff/1/Source/core/frame/DOMWindow.cpp#newcode1217 Source/core/frame/DOMWindow.cpp:1217: return m_frame->tree().name(); This returns a "const AtomicString&" https://codereview.chromium.org/89943002/diff/1/Source/core/frame/DOMWindow.cpp#newcode1225 Source/core/frame/DOMWindow.cpp:1225: ...
7 years ago (2013-11-27 00:31:00 UTC) #1
Inactive
7 years ago (2013-11-27 02:48:02 UTC) #2
haraken
LGTM
7 years ago (2013-11-27 03:21:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/89943002/1
7 years ago (2013-11-27 04:08:18 UTC) #4
commit-bot: I haz the power
7 years ago (2013-11-27 10:01:31 UTC) #5
Message was sent while issue was closed.
Change committed as 162746

Powered by Google App Engine
This is Rietveld 408576698