Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: Source/core/frame/DOMWindow.cpp

Issue 89943002: Have DOMWindow name getter / setter deal with AtomicStrings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/DOMWindow.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/DOMWindow.cpp
diff --git a/Source/core/frame/DOMWindow.cpp b/Source/core/frame/DOMWindow.cpp
index b47293e902d9c8ebd5ce6a10aa88ce4ecdcd3c85..b5109df150392715898e04c97914a4eed0041921 100644
--- a/Source/core/frame/DOMWindow.cpp
+++ b/Source/core/frame/DOMWindow.cpp
@@ -1209,21 +1209,21 @@ unsigned DOMWindow::length() const
return m_frame->tree().scopedChildCount();
}
-String DOMWindow::name() const
+const AtomicString& DOMWindow::name() const
{
if (!m_frame)
- return String();
+ return nullAtom;
return m_frame->tree().name();
Inactive 2013/11/27 00:31:00 This returns a "const AtomicString&"
}
-void DOMWindow::setName(const String& string)
+void DOMWindow::setName(const AtomicString& name)
{
if (!m_frame)
return;
- m_frame->tree().setName(string);
- m_frame->loader().client()->didChangeName(string);
+ m_frame->tree().setName(name);
Inactive 2013/11/27 00:31:00 This takes a "const AtomicString&" in argument.
+ m_frame->loader().client()->didChangeName(name);
}
void DOMWindow::setStatus(const String& string)
« no previous file with comments | « Source/core/frame/DOMWindow.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698