Linux: Enable ODR violation detection.

Linux: Enable ODR violation detection.

BUG=449754
Committed: https://crrev.com/e86588abd0f3b65777d8bc679747eeb6bbdf21f8
Cr-Commit-Position: refs/heads/master@{#315906}

[Lei Zhang, 2015-02-06 08:57:07]

thestig@chromium.org changed reviewers:
+ thakis@chromium.org

[Lei Zhang, 2015-02-06 08:57:08]

Should be good to go once https://codereview.chromium.org/874883003/ lands. I've
already filed a bug for libphonenumber_unittests: http://crbug.com/456021

[Nico, 2015-02-06 15:46:04]

lgtm, nice!

https://codereview.chromium.org/899403003/diff/20001/build/config/compiler/BU...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/899403003/diff/20001/build/config/compiler/BU...
build/config/compiler/BUILD.gn:486: }
You can have a local config in the libphonenumber build file, like so:
https://codereview.chromium.org/722513003/diff/120001/third_party/libphonenum...
(…oh hey, the example is in libphonenumber too!)

[Lei Zhang, 2015-02-06 23:42:05]

New patchsets have been uploaded after l-g-t-m from thakis@chromium.org

[Lei Zhang, 2015-02-06 23:44:55]

https://codereview.chromium.org/899403003/diff/20001/build/config/compiler/BU...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/899403003/diff/20001/build/config/compiler/BU...
build/config/compiler/BUILD.gn:486: }
On 2015/02/06 15:46:04, Nico wrote:
> You can have a local config in the libphonenumber build file, like so:
>
https://codereview.chromium.org/722513003/diff/120001/third_party/libphonenum...
> (…oh hey, the example is in libphonenumber too!)

Oh, I tried that, but I needed to duplicate the |use_gold| variable. Is there a
way to reference a variable in another .gn file?

[Nico, 2015-02-07 00:24:20]

Not sure. Depends on the variable, I think (?)

On Fri, Feb 6, 2015 at 3:44 PM, <thestig@chromium.org> wrote:

>
> https://codereview.chromium.org/899403003/diff/20001/
> build/config/compiler/BUILD.gn
> File build/config/compiler/BUILD.gn (right):
>
> https://codereview.chromium.org/899403003/diff/20001/
> build/config/compiler/BUILD.gn#newcode486
> build/config/compiler/BUILD.gn:486: }
> On 2015/02/06 15:46:04, Nico wrote:
>
>> You can have a local config in the libphonenumber build file, like so:
>>
>
> https://codereview.chromium.org/722513003/diff/120001/
> third_party/libphonenumber/BUILD.gn
>
>> (…oh hey, the example is in libphonenumber too!)
>>
>
> Oh, I tried that, but I needed to duplicate the |use_gold| variable. Is
> there a way to reference a variable in another .gn file?
>
> https://codereview.chromium.org/899403003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Lei Zhang, 2015-02-07 00:34:32]

On 2015/02/07 00:24:20, Nico wrote:
> Not sure. Depends on the variable, I think (?)

Maybe if |use_gold| was in a .gni file somewhere. I'm inclined to just leave it
as is.

[Lei Zhang, 2015-02-07 00:34:50]

thestig@chromium.org changed reviewers:
+ isherman@chromium.org

[Lei Zhang, 2015-02-07 00:34:51]

+isherman for libphonenumber.

[Ilya Sherman, 2015-02-07 01:01:29]

libphonenumber lgtm, thanks

[Nico, 2015-02-10 16:51:46]

Are you going to land this?

[Lei Zhang, 2015-02-10 20:01:55]

On 2015/02/10 16:51:46, Nico wrote:
> Are you going to land this?

Gotta land https://codereview.chromium.org/874883003/ first.

[Lei Zhang, 2015-02-10 22:33:57]

New patchsets have been uploaded after l-g-t-m from isherman@chromium.org

[Lei Zhang, 2015-02-11 00:10:53]

On 2015/02/10 20:01:55, Lei Zhang wrote:
> On 2015/02/10 16:51:46, Nico wrote:
> > Are you going to land this?
> 
> Gotta land https://codereview.chromium.org/874883003/ first.

Did that, ran some try jobs, found more errors. So I guess the answer is no.

[Nico, 2015-02-11 01:28:37]

Maybe enable it for one config first?
On Feb 10, 2015 4:10 PM, <thestig@chromium.org> wrote:

> On 2015/02/10 20:01:55, Lei Zhang wrote:
>
>> On 2015/02/10 16:51:46, Nico wrote:
>> > Are you going to land this?
>>
>
>  Gotta land https://codereview.chromium.org/874883003/ first.
>>
>
> Did that, ran some try jobs, found more errors. So I guess the answer is
> no.
>
> https://codereview.chromium.org/899403003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Lei Zhang, 2015-02-11 02:30:23]

On 2015/02/11 01:28:37, Nico wrote:
> Maybe enable it for one config first?

Sure. I uplaoded patch set 6, but it turns out we also need to roll pdfium past
https://codereview.chromium.org/896023003 ...

[Lei Zhang, 2015-02-12 00:35:17]

On 2015/02/11 02:30:23, Lei Zhang wrote:
> On 2015/02/11 01:28:37, Nico wrote:
> > Maybe enable it for one config first?
> 
> Sure. I uplaoded patch set 6, but it turns out we also need to roll pdfium
past
> https://codereview.chromium.org/896023003 ...

pdfium rolled yesterday, landing patch set 6.

[Lei Zhang, 2015-02-12 00:35:28]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-02-12 00:36:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/899403003/100001

[commit-bot: I haz the power, 2015-02-12 02:04:21]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-02-12 02:05:04]

Patchset 6 (id:??) landed as
https://crrev.com/e86588abd0f3b65777d8bc679747eeb6bbdf21f8
Cr-Commit-Position: refs/heads/master@{#315906}

[Lei Zhang, 2015-02-12 02:48:16]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/874743007/ by thestig@chromium.org.

The reason for reverting is:
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%...
found more ODR violations in libjingle..

[Nico, 2015-02-12 05:31:02]

Maybe only turn it off for buildtype=Official instead of reverting…

On Wed, Feb 11, 2015 at 6:48 PM, <thestig@chromium.org> wrote:

> A revert of this CL (patchset #6 id:100001) has been created in
> https://codereview.chromium.org/874743007/ by thestig@chromium.org.
>
> The reason for reverting is:
> http://build.chromium.org/p/chromium.chrome/builders/
> Google%20Chrome%20Linux%20x64/builds/55780
> found more ODR violations in libjingle..
>
> https://codereview.chromium.org/899403003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.