Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 8992026: Merge 102519 - WebPImageDecoder progressive decodes fail to decode valid images (Closed)

9 years ago by kerz_chromium
9 years ago
Base URL:


Merge 102519 - WebPImageDecoder progressive decodes fail to decode valid images Reviewed by Adam Barth. The WEBP header is followed by a so-called P0 header, then some data to decode. If a partial P0 header is received during progressive decodes, WebPIDecGetRGB() returns false; that makes the decoder enter the failed state, no image appears on the page. James Zern (webp) recommended the following via e-mail: WebPIUpdate() validates input data, and will return an error status for malformed data (bit-stream error, invalid data). Otherwise, it returns OK or SUSPENDED. OK means that decoding is done/complete/no-error, and SUSPENDED means more input data is needed to complete decoding. A NULL return from WebPIDecGetRGB() is valid at this time due to a partial P0, and should not be interpreted as a decoding failure. No new tests. Not something DumpRenderTree can easily test. * platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::decode): A NULL WebPIDecGetRGB() return is acceptable here. Return false instead of failing the decoder. Committed:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1945 lines, -1 line) Patch
M Source/WebCore/ChangeLog View 1 chunk +1944 lines, -0 lines 0 comments Download
M Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download


Total messages: 2 (0 generated)
9 years ago (2011-12-19 22:31:40 UTC) #1
Noel Gordon
9 years ago (2011-12-20 00:55:38 UTC) #2

Powered by Google App Engine
This is Rietveld 408576698