chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc - Issue 899173002: Replace Webstore link with app info dialog link in chrome://apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

Issue 899173002: Replace Webstore link with app info dialog link in chrome://apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/apps/app_info_dialog.h ('K') | « chrome/browser/ui/apps/app_info_dialog.h ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

index 734f1f72633dd684c4e9a87fe29fe8017e6f3782..6e69445d43f812f9380840303d70de376330349c 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

@@ -20,6 +20,7 @@

#include "extensions/common/extension.h"

#include "extensions/common/manifest.h"

#include "ui/app_list/app_list_constants.h"

+#include "ui/app_list/app_list_switches.h"

#include "ui/gfx/geometry/rect.h"

#include "ui/gfx/geometry/size.h"

#include "ui/views/border.h"

@@ -29,6 +30,18 @@

#include "ui/views/widget/widget.h"

#include "ui/views/window/dialog_delegate.h"

+bool CanShowAppInfoDialog() {

+#if defined(OS_MACOSX)

+ return app_list::switches::IsMacViewsAppListListEnabled();

+#else

+ return true;

+#endif

+gfx::Size GetAppInfoNativeDialogSize() {

+ return gfx::Size(380, 490);

void ShowAppInfoInAppList(gfx::NativeWindow parent,

const gfx::Rect& app_list_bounds,

Profile* profile,