chrome/browser/ui/apps/app_info_dialog.h - Issue 899173002: Replace Webstore link with app info dialog link in chrome://apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/apps/app_info_dialog.h

Issue 899173002: Replace Webstore link with app info dialog link in chrome://apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_controller_delegate.cc ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/apps/app_info_dialog.h

diff --git a/chrome/browser/ui/apps/app_info_dialog.h b/chrome/browser/ui/apps/app_info_dialog.h

index 35989485281d5affe94a9b4534f359d2a86dfef7..70bce0cc08a323fee708e0c51151b1af5b02ff43 100644

--- a/chrome/browser/ui/apps/app_info_dialog.h

+++ b/chrome/browser/ui/apps/app_info_dialog.h

@@ -23,9 +23,16 @@ class Size;

enum AppInfoLaunchSource {

FROM_APP_LIST, // Launched from the app list context menu.

FROM_EXTENSIONS_PAGE, // Launched from the chrome://extensions page.

+ FROM_APPS_PAGE, // Launched from chrome://apps context menu.

NUM_LAUNCH_SOURCES,

};

+// Returns true if the app info dialog is available on the current platform.

+bool CanShowAppInfoDialog();

tapted 2015/02/13 08:11:59 ooh. I think you'l need to "implement" these in ch

+// Returns the size of the native window container for the app info dialog.

+gfx::Size GetAppInfoNativeDialogSize();

// Shows the chrome app information as a frameless window for the given |app|

// and |profile| at the given |app_list_bounds|. Appears 'inside' the app list.

void ShowAppInfoInAppList(gfx::NativeWindow parent,