Replace Webstore link with app info dialog link in chrome://apps

chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

Index: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
index 244c8e4e07294ec253fe7435cc30a0c470518c3e..23c72e6110e4c31f10d39c3487eabaa872ac82a8 100644
--- a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
@@ -159,6 +159,14 @@ std::string GetNewTabBackgroundTilingCSS(
   return ThemeProperties::TilingToString(repeat_mode);
 }
 
+bool ShouldDisplayAppInfoDialog() {

[tsergeant, 2015/02/05 05:33:27]

Is there a good way to avoid adding new logic to figure whether the app info
dialog is available? This is mostly a duplicate of
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

[sashab, 2015/02/06 16:23:00]

Hmm... This would be perfect as a static method to AppInfoDialog, but it has a
views dependency so can't be imported on Mac :)
Actually, maybe it can... Check with Trent and maybe put it there,
AppInfoDialog::CanDisplayInNativeDialog() and
AppInfoDialog::CanDisplayInAppList() (since we will probably enable the two
separately) and update the dependency you linked to as well.

Otherwise, maybe add them as just plain methods to app_info_dialog.h.

[tsergeant, 2015/02/09 03:10:49]

I already tried something similar. Adding a method to AppInfoDialog in
`chrome/browser/ui/views/app_info_dialog_views.h` doesn't work, because
`chrome/browser/ui/DEPS` prevents importing from `chrome/browser/ui/views` in
this file.

Adding it to `app_info_dialog` should work. There's also
`ui/app_list/app_list_switches`, which contains `IsAppInfoEnabled`, which is
used in the applist itself.

There's also a slight difficulty since the `extension_settings_handler` version
has a flag which doesn't necessarily apply elsewhere.

[sashab, 2015/02/09 11:47:07]

Don't really want to put it in switches, since that's more for command-line
flags. I can see IsAppInfoEnabled() but don't really like it (since 'enabled'
doesn't really define its location).

How's this... move IsAppInfoEnabled into app_info_dialog as suggested below, and
make it take the location parameter. Now the logic is:

// Returns whether the app info dialog can be launched on this platform from the
given location.
bool CanLaunchAppInfoDialogFrom(location) {
if location == app list
   <old IsAppInfoEnabled logic here>
   return

if mac
  return false
return true
}

Thoughts?

+#if defined(OS_MACOSX)
+  return false;
+#else
+  return true;
+#endif
+}
+
 }  // namespace
 
 NTPResourceCache::NTPResourceCache(Profile* profile)
@@ -439,6 +447,8 @@ void NTPResourceCache::CreateNewTabHTML() {
       l10n_util::GetStringUTF16(IDS_NEW_TAB_APP_OPTIONS));
   load_time_data.SetString("appdetails",
       l10n_util::GetStringUTF16(IDS_NEW_TAB_APP_DETAILS));
+  load_time_data.SetString("appinfodialog",
+      l10n_util::GetStringUTF16(IDS_NEW_TAB_APP_INFO));
   load_time_data.SetString("appcreateshortcut",
       l10n_util::GetStringUTF16(IDS_NEW_TAB_APP_CREATE_SHORTCUT));
   load_time_data.SetString("appDefaultPageName",
@@ -508,6 +518,9 @@ void NTPResourceCache::CreateNewTabHTML() {
         l10n_util::GetStringUTF16(IDS_APP_CONTEXT_MENU_OPEN_TAB));
   }
 
+  load_time_data.SetBoolean("enableAppInfoDialog",
+      ShouldDisplayAppInfoDialog());
+
 #if defined(OS_CHROMEOS)
   load_time_data.SetString("expandMenu",
       l10n_util::GetStringUTF16(IDS_NEW_TAB_CLOSE_MENU_EXPAND));