Replace Webstore link with app info dialog link in chrome://apps

chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/ntp_resource_cache.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 141 matching lines @@
 
 // How the background image on the new tab page should be tiled (see tiling
 // masks in theme_service.h).
 std::string GetNewTabBackgroundTilingCSS(
     const ui::ThemeProvider* theme_provider) {
   int repeat_mode = theme_provider->GetDisplayProperty(
       ThemeProperties::NTP_BACKGROUND_TILING);
   return ThemeProperties::TilingToString(repeat_mode);
 }
 
+bool ShouldDisplayAppInfoDialog() {

[tsergeant, 2015/02/05 05:33:27]

Is there a good way to avoid adding new logic to figure whether the app info
dialog is available? This is mostly a duplicate of
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

[sashab, 2015/02/06 16:23:00]

Hmm... This would be perfect as a static method to AppInfoDialog, but it has a
views dependency so can't be imported on Mac :)
Actually, maybe it can... Check with Trent and maybe put it there,
AppInfoDialog::CanDisplayInNativeDialog() and
AppInfoDialog::CanDisplayInAppList() (since we will probably enable the two
separately) and update the dependency you linked to as well.

Otherwise, maybe add them as just plain methods to app_info_dialog.h.

[tsergeant, 2015/02/09 03:10:49]

I already tried something similar. Adding a method to AppInfoDialog in
`chrome/browser/ui/views/app_info_dialog_views.h` doesn't work, because
`chrome/browser/ui/DEPS` prevents importing from `chrome/browser/ui/views` in
this file.

Adding it to `app_info_dialog` should work. There's also
`ui/app_list/app_list_switches`, which contains `IsAppInfoEnabled`, which is
used in the applist itself.

There's also a slight difficulty since the `extension_settings_handler` version
has a flag which doesn't necessarily apply elsewhere.

[sashab, 2015/02/09 11:47:07]

Don't really want to put it in switches, since that's more for command-line
flags. I can see IsAppInfoEnabled() but don't really like it (since 'enabled'
doesn't really define its location).

How's this... move IsAppInfoEnabled into app_info_dialog as suggested below, and
make it take the location parameter. Now the logic is:

// Returns whether the app info dialog can be launched on this platform from the
given location.
bool CanLaunchAppInfoDialogFrom(location) {
if location == app list
   <old IsAppInfoEnabled logic here>
   return

if mac
  return false
return true
}

Thoughts?

+#if defined(OS_MACOSX)
+  return false;
+#else
+  return true;
+#endif
+}
+
 }  // namespace
 
 NTPResourceCache::NTPResourceCache(Profile* profile)
     : profile_(profile), is_swipe_tracking_from_scroll_events_enabled_(false),
       should_show_apps_page_(NewTabUI::ShouldShowApps()),
       should_show_most_visited_page_(true),
       should_show_other_devices_menu_(true),
       should_show_recently_closed_menu_(true) {
   registrar_.Add(this, chrome::NOTIFICATION_BROWSER_THEME_CHANGED,
                  content::Source<ThemeService>(
@@ skipping 260 matching lines @@
   load_time_data.SetString("undothumbnailremove",
       l10n_util::GetStringUTF16(IDS_NEW_TAB_UNDO_THUMBNAIL_REMOVE));
   load_time_data.SetString("removethumbnailtooltip",
       l10n_util::GetStringUTF16(IDS_NEW_TAB_REMOVE_THUMBNAIL_TOOLTIP));
   load_time_data.SetString("appuninstall",
       l10n_util::GetStringUTF16(IDS_EXTENSIONS_UNINSTALL));
   load_time_data.SetString("appoptions",
       l10n_util::GetStringUTF16(IDS_NEW_TAB_APP_OPTIONS));
   load_time_data.SetString("appdetails",
       l10n_util::GetStringUTF16(IDS_NEW_TAB_APP_DETAILS));
+  load_time_data.SetString("appinfodialog",
+      l10n_util::GetStringUTF16(IDS_NEW_TAB_APP_INFO));
   load_time_data.SetString("appcreateshortcut",
       l10n_util::GetStringUTF16(IDS_NEW_TAB_APP_CREATE_SHORTCUT));
   load_time_data.SetString("appDefaultPageName",
       l10n_util::GetStringUTF16(IDS_APP_DEFAULT_PAGE_NAME));
   load_time_data.SetString("applaunchtypepinned",
       l10n_util::GetStringUTF16(IDS_APP_CONTEXT_MENU_OPEN_PINNED));
   load_time_data.SetString("applaunchtyperegular",
       l10n_util::GetStringUTF16(IDS_APP_CONTEXT_MENU_OPEN_REGULAR));
   load_time_data.SetString("applaunchtypewindow",
       l10n_util::GetStringUTF16(IDS_APP_CONTEXT_MENU_OPEN_WINDOW));
@@ skipping 49 matching lines @@
 
   bool bookmark_apps_enabled = extensions::util::IsNewBookmarkAppsEnabled();
   load_time_data.SetBoolean("enableNewBookmarkApps", bookmark_apps_enabled);
   // Use a different string for launching as a regular tab when bookmark apps
   // are enabled.
   if (bookmark_apps_enabled) {
     load_time_data.SetString("applaunchtypetab",
         l10n_util::GetStringUTF16(IDS_APP_CONTEXT_MENU_OPEN_TAB));
   }
 
+  load_time_data.SetBoolean("enableAppInfoDialog",
+      ShouldDisplayAppInfoDialog());
+
 #if defined(OS_CHROMEOS)
   load_time_data.SetString("expandMenu",
       l10n_util::GetStringUTF16(IDS_NEW_TAB_CLOSE_MENU_EXPAND));
 #endif
 
   NewTabPageHandler::GetLocalizedValues(profile_, &load_time_data);
   NTPLoginHandler::GetLocalizedValues(profile_, &load_time_data);
 
   webui::SetLoadTimeDataDefaults(app_locale, &load_time_data);
 
@@ skipping 199 matching lines @@
   // Get our template.
   static const base::StringPiece new_tab_theme_css(
       ResourceBundle::GetSharedInstance().GetRawDataResource(
           IDR_NEW_TAB_4_THEME_CSS));
 
   // Create the string from our template and the replacements.
   std::string css_string;
   css_string = ReplaceStringPlaceholders(new_tab_theme_css, subst, NULL);
   new_tab_css_ = base::RefCountedString::TakeString(&css_string);
 }