Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 899163007: extension: fix typo that breaks showing extension options dialog. (Closed)

Created:
5 years, 10 months ago by Dan Beam
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

extension: fix typo that breaks showing extension options dialog. R=kalman@chromium.org BUG=none (yet) Committed: https://crrev.com/fbc55181889b62ea98b6db6defb753728dafe90c Cr-Commit-Position: refs/heads/master@{#314887}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -17 lines) Patch
M chrome/browser/resources/extensions/extension_options_overlay.js View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.js View 4 chunks +40 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dan Beam
https://codereview.chromium.org/899163007/diff/1/chrome/browser/resources/extensions/extension_options_overlay.js File chrome/browser/resources/extensions/extension_options_overlay.js (right): https://codereview.chromium.org/899163007/diff/1/chrome/browser/resources/extensions/extension_options_overlay.js#newcode134 chrome/browser/resources/extensions/extension_options_overlay.js:134: var loading = document.documentElement.classList.contains('loading'); dammit
5 years, 10 months ago (2015-02-05 20:33:35 UTC) #1
not at google - send to devlin
lgtm
5 years, 10 months ago (2015-02-05 20:39:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899163007/1
5 years, 10 months ago (2015-02-05 20:45:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 21:54:34 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 21:55:39 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fbc55181889b62ea98b6db6defb753728dafe90c
Cr-Commit-Position: refs/heads/master@{#314887}

Powered by Google App Engine
This is Rietveld 408576698