chrome/browser/resources/extensions/extension_options_overlay.js - Issue 899163007: extension: fix typo that breaks showing extension options dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_options_overlay.js

Issue 899163007: extension: fix typo that breaks showing extension options dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/extensions/extension_options_overlay.js

diff --git a/chrome/browser/resources/extensions/extension_options_overlay.js b/chrome/browser/resources/extensions/extension_options_overlay.js

index e51e8c09e7b675411d5e6bac4b039f93bed4d9b1..eb15741494d56b13a29cacee6ee97211b873681a 100644

--- a/chrome/browser/resources/extensions/extension_options_overlay.js

+++ b/chrome/browser/resources/extensions/extension_options_overlay.js

@@ -131,7 +131,7 @@ cr.define('extensions', function() {

// the overlay. It is calculated by multiplying the pythagorean distance

// between old and the new size (in px) with a constant speed of

// 0.25 ms/px.

- var loading = document.documentElement.classlist.contains('loading');

+ var loading = document.documentElement.classList.contains('loading');

Dan Beam 2015/02/05 20:33:35 dammit

var animationTime = loading ? 0 :

0.25 * Math.sqrt(Math.pow(newWidth - oldWidth, 2) +

Math.pow(newHeight - oldHeight, 2));

« no previous file with comments | « no previous file | chrome/browser/ui/webui/extensions/extension_settings_browsertest.js » ('j') | no next file with comments »