Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Issue 899113002: Manual revert of Timezone auto update option should be available by default. (Closed)

Created:
5 years, 10 months ago by kelvinp
Modified:
5 years, 10 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manual revert of Timezone auto update option should be available by default. Reason for revert: 4000+ browser test are failing on ChromeOS after this patch and this is the only patch that touches ChromeOS in the blamelist. Seems like with the switch enabled, we are creating the GetTimezoneResolver that leaks the g_browser_process->system_request_context() Sample failure: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/37149 Original issue's description: > https://codereview.chromium.org/898503002 > Timezone auto update option should be available by default. > > This CL makes "timezone auto update" feature available (but > switched off by > default) to users. And adds flag to disable this feature. > > BUG=416494 > TEST=manual > > Committed: > https://crrev.com/13bb9e13b4719c96112ca8770d2c7b48c23e150d > Cr-Commit-Position: refs/heads/master@{#314615} TBR=alemate TEST=MANUAL NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true Committed: https://crrev.com/44036d053dc7731deb8fdf5d20603bbb8b1c19a5 Cr-Commit-Position: refs/heads/master@{#314663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -20 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
kelvinp
5 years, 10 months ago (2015-02-04 22:25:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/899113002/1
5 years, 10 months ago (2015-02-04 22:39:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 22:41:19 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 22:42:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44036d053dc7731deb8fdf5d20603bbb8b1c19a5
Cr-Commit-Position: refs/heads/master@{#314663}

Powered by Google App Engine
This is Rietveld 408576698