Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 898503002: Timezone auto update option should be available by default. (Closed)

Created:
5 years, 10 months ago by Alexander Alekseev
Modified:
5 years, 10 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timezone auto update option should be available by default. This CL makes "timezone auto update" feature available (but switched off by default) to users. And adds flag to disable this feature. BUG=416494 TEST=manual Committed: https://crrev.com/13bb9e13b4719c96112ca8770d2c7b48c23e150d Cr-Commit-Position: refs/heads/master@{#314615}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update message string. #

Patch Set 3 : Update histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
Alexander Alekseev
Please review. stevenjb@ : chrome/browser/ui/webui/options/browser_options_handler.* dpolukhin@ : All
5 years, 10 months ago (2015-02-02 17:47:20 UTC) #2
stevenjb
lgtm https://codereview.chromium.org/898503002/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/898503002/diff/1/chrome/app/chromeos_strings.grdp#newcode6042 chrome/app/chromeos_strings.grdp:6042: If enabled, automatic timezone update by the current ...
5 years, 10 months ago (2015-02-02 21:14:40 UTC) #3
Alexander Alekseev
https://codereview.chromium.org/898503002/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/898503002/diff/1/chrome/app/chromeos_strings.grdp#newcode6042 chrome/app/chromeos_strings.grdp:6042: If enabled, automatic timezone update by the current geolocation ...
5 years, 10 months ago (2015-02-03 08:29:57 UTC) #4
Alexander Alekseev
isherman@ : please review tools/metrics/histograms/histograms.xml
5 years, 10 months ago (2015-02-03 09:23:08 UTC) #6
Ilya Sherman
histograms.xml lgtm
5 years, 10 months ago (2015-02-03 22:24:13 UTC) #7
Dmitry Polukhin
lgtm
5 years, 10 months ago (2015-02-04 13:28:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898503002/40001
5 years, 10 months ago (2015-02-04 13:32:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/22787)
5 years, 10 months ago (2015-02-04 15:20:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898503002/40001
5 years, 10 months ago (2015-02-04 19:08:44 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-04 20:07:55 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 20:10:10 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/13bb9e13b4719c96112ca8770d2c7b48c23e150d
Cr-Commit-Position: refs/heads/master@{#314615}

Powered by Google App Engine
This is Rietveld 408576698