chrome/browser/printing/print_preview_dialog_controller.cc - Issue 899033002: Revert of Combine PDF plugin into the Chromium binary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_dialog_controller.cc

Issue 899033002: Revert of Combine PDF plugin into the Chromium binary. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/component_loader.cc ('k') | chrome/browser/printing/print_preview_pdf_generated_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_preview_dialog_controller.cc

diff --git a/chrome/browser/printing/print_preview_dialog_controller.cc b/chrome/browser/printing/print_preview_dialog_controller.cc

index ad996d32bce4f6e9c9c4c5d7f90ed057a02cd20d..1075f61ad69c8eee5c7be1c1e55a91278903ac22 100644

--- a/chrome/browser/printing/print_preview_dialog_controller.cc

+++ b/chrome/browser/printing/print_preview_dialog_controller.cc

@@ -52,8 +52,9 @@

void EnableInternalPDFPluginForContents(WebContents* preview_dialog) {

// Always enable the internal PDF plugin for the print preview page.

- base::FilePath pdf_plugin_path = base::FilePath::FromUTF8Unsafe(

- ChromeContentClient::kPDFPluginPath);

+ base::FilePath pdf_plugin_path;

+ if (!PathService::Get(chrome::FILE_PDF_PLUGIN, &pdf_plugin_path))

+ return;

content::WebPluginInfo pdf_plugin;

if (!content::PluginService::GetInstance()->GetPluginInfoByPath(