tools/dom/scripts/htmlrenamer.py - Issue 898993002: Clamp scrollX, scrollY, pageXOffset, and pageYOffset from double to int

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/htmlrenamer.py

Issue 898993002: Clamp scrollX, scrollY, pageXOffset, and pageYOffset from double to int (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/html/dartium/html_dartium.dart ('K') | « sdk/lib/html/dartium/html_dartium.dart ('k') | tools/dom/templates/html/impl/impl_Window.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/scripts/htmlrenamer.py

diff --git a/tools/dom/scripts/htmlrenamer.py b/tools/dom/scripts/htmlrenamer.py

index f54b81662754131ce71117522b4082678490617c..92aa17ed886adf8bb302d9ba1c1c4a90f0b4c703 100644

--- a/tools/dom/scripts/htmlrenamer.py

+++ b/tools/dom/scripts/htmlrenamer.py

@@ -380,6 +380,13 @@ private_html_members = monitored.Set('htmlrenamer.private_html_members', [

'Window.getComputedStyle',

'Window.clearInterval',

'Window.clearTimeout',

+ # TODO(tll): These have been converted from int to double in Chrome 39 for

+ # subpixel precision. Special case for backward compatibility.

+ 'Window.scrollX',

+ 'Window.scrollY',

+ 'Window.pageXOffset',

+ 'Window.pageYOffset',

'WindowTimers.clearInterval',

'WindowTimers.clearTimeout',

'WindowTimers.setInterval',

« sdk/lib/html/dartium/html_dartium.dart ('K') | « sdk/lib/html/dartium/html_dartium.dart ('k') | tools/dom/templates/html/impl/impl_Window.darttemplate » ('j') | no next file with comments »