Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 898993002: Clamp scrollX, scrollY, pageXOffset, and pageYOffset from double to int (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tools/dom/scripts/htmlrenamer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index cd867e53494c5baed2fa26488c46e732af1fb39b..617d247f4629756dca58c9f9366e3913b565f28e 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -33207,7 +33207,7 @@ class Window extends EventTarget implements WindowEventHandlers, WindowBase, Glo
*/
@DomName('Window.pageXOffset')
@DocsEditable()
- int get pageXOffset => _blink.BlinkWindow.instance.pageXOffset_Getter_(this);
+ int get _pageXOffset => _blink.BlinkWindow.instance.pageXOffset_Getter_(this);
vsm 2015/02/04 17:10:43 Should this be typed int or double? If int, why d
terry 2015/02/04 17:19:25 It should be double (I'll make the 39 roll IDL cha
/**
* The distance this window has been scrolled vertically.
@@ -33223,7 +33223,7 @@ class Window extends EventTarget implements WindowEventHandlers, WindowBase, Glo
*/
@DomName('Window.pageYOffset')
@DocsEditable()
- int get pageYOffset => _blink.BlinkWindow.instance.pageYOffset_Getter_(this);
+ int get _pageYOffset => _blink.BlinkWindow.instance.pageYOffset_Getter_(this);
@DomName('Window.parent')
@DocsEditable()
@@ -33310,11 +33310,11 @@ class Window extends EventTarget implements WindowEventHandlers, WindowBase, Glo
@DomName('Window.scrollX')
@DocsEditable()
- int get scrollX => _blink.BlinkWindow.instance.scrollX_Getter_(this);
+ int get _scrollX => _blink.BlinkWindow.instance.scrollX_Getter_(this);
@DomName('Window.scrollY')
@DocsEditable()
- int get scrollY => _blink.BlinkWindow.instance.scrollY_Getter_(this);
+ int get _scrollY => _blink.BlinkWindow.instance.scrollY_Getter_(this);
/**
* This window's scroll bars.
@@ -34118,6 +34118,21 @@ class Window extends EventTarget implements WindowEventHandlers, WindowBase, Glo
_moveTo(p.x, p.y);
}
+ @DomName('Window.pageXOffset')
+ @DocsEditable()
+ int get pageXOffset => _blink.BlinkWindow.instance.pageXOffset_Getter_(this).round();
+
+ @DomName('Window.pageYOffset')
+ @DocsEditable()
+ int get pageYOffset => _blink.BlinkWindow.instance.pageYOffset_Getter_(this).round();
+
+ @DomName('Window.scrollX')
+ @DocsEditable()
+ int get scrollX => _blink.BlinkWindow.instance.scrollX_Getter_(this).round();
+
+ @DomName('Window.scrollY')
+ @DocsEditable()
+ int get scrollY => _blink.BlinkWindow.instance.scrollY_Getter_(this).round();
}
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tools/dom/scripts/htmlrenamer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698