Issue 898973003: Revert "[turbofan] Make Factory::NewNumber() always return the minus_zero_value."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 898973003: Revert "[turbofan] Make Factory::NewNumber() always return the minus_zero_value." (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer

Modified:
5 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert "[turbofan] Make Factory::NewNumber() always return the minus_zero_value." This reverts commit f578d35ba8d6798afe45cd60f4f06bfa7e2ae6be because (immutable) heap numbers are surprisingly mutable in V8. Someone else might want to cleanup the mess, otherwise we'll just keep it this way. TBR=jkummerow@chromium.org BUG=chromium:454894 LOG=y Committed: https://chromium.googlesource.com/v8/v8/+/9dff8185dd6f1e7e25fe3e9818893d812088b967

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -67 lines)			Patch
M	src/factory.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ic/ic.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	test/unittests/factory-unittest.cc	View	1 chunk	+0 lines, -52 lines	0 comments	Download
M	test/unittests/unittests.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/9dff8185dd6f1e7e25fe3e9818893d812088b967 Cr-Commit-Position: refs/heads/master@{#26447}

5 years, 10 months ago (2015-02-05 04:58:58 UTC) #2

Benedikt Meurer

Committed patchset #1 (id:1) manually as 9dff8185dd6f1e7e25fe3e9818893d812088b967 (tree was closed).

5 years, 10 months ago (2015-02-05 04:58:59 UTC) #3

Message was sent while issue was closed.

lgtm