Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 898883003: Fixes play seek when user sets loop after ended. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Responding to feedback #3 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/media/video-loop-from-ended-expected.txt ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.h
diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h
index 6f539a0bd30757c50c9e939d57f7547960ee2ceb..4874cde5959676cb8f2d6176c89915a6c2c371ff 100644
--- a/Source/core/html/HTMLMediaElement.h
+++ b/Source/core/html/HTMLMediaElement.h
@@ -411,10 +411,15 @@ private:
void updateVolume();
void updatePlayState();
bool potentiallyPlaying() const;
- bool endedPlayback() const;
bool stoppedDueToErrors() const;
bool couldPlayIfEnoughData() const;
+ // Generally the presence of the loop attribute should be considered to mean playback
+ // has not "ended", as "ended" and "looping" are mutually exclusive. See
+ // https://html.spec.whatwg.org/multipage/embedded-content.html#ended-playback
+ enum class LoopCondition { Included, Ignored };
+ bool endedPlayback(LoopCondition = LoopCondition::Included) const;
+
void setShouldDelayLoadEvent(bool);
void invalidateCachedTime();
void refreshCachedTime() const;
« no previous file with comments | « LayoutTests/media/video-loop-from-ended-expected.txt ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698