Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: LayoutTests/media/video-loop-from-ended-expected.txt

Issue 898883003: Fixes play seek when user sets loop after ended. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Responding to feedback #3 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/media/video-loop-from-ended.html ('k') | Source/core/html/HTMLMediaElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/media/video-loop-from-ended-expected.txt
diff --git a/LayoutTests/media/video-loop-from-ended-expected.txt b/LayoutTests/media/video-loop-from-ended-expected.txt
new file mode 100644
index 0000000000000000000000000000000000000000..37d35a64ad2188c32451840a700d685db52624cf
--- /dev/null
+++ b/LayoutTests/media/video-loop-from-ended-expected.txt
@@ -0,0 +1,49 @@
+Test looping edge case to verify http://crbug.com/364442. Steps:
+
+Seek toward end of video (for faster testing).
+Play video to end with 'loop' set to false.
+Once ended, set 'loop' to true.
+Call play.
+Verify that 'seeked' event fires, seeking back to the beginning.
+Pause video and end test.
+
+++ Video is initially paused and 'loop' unset.
+EXPECTED (video.paused == 'true') OK
+EXPECTED (video.loop == 'false') OK
+
+++ Seek to just before the end of the video and play.
+RUN(video.currentTime = video.duration - .5)
+RUN(video.play())
+
+EVENT(play)
+EVENT(ended)
+
+++ Verify played to end and stopped.
+EXPECTED (video.ended == 'true') OK
+EXPECTED (video.paused == 'true') OK
+EXPECTED (video.currentTime == 'video.duration') OK
+
+++ With playback ended, set 'loop' attribute. This will cause ended == false; looping video cannot be 'ended', only paused.
+EXPECTED (video.loop == 'false') OK
+RUN(video.loop = true)
+EXPECTED (video.loop == 'true') OK
+EXPECTED (video.ended == 'false') OK
+EXPECTED (video.paused == 'true') OK
+
+++ Play video with 'loop' set. Expect seek back to start.
+RUN(video.play())
+
+EVENT(play)
+EVENT(seeked)
+
+++ Observed seek. Verify current time decreased and still playing.
+EXPECTED (video.loop == 'true') OK
+EXPECTED (video.paused == 'false') OK
+EXPECTED (video.ended == 'false') OK
+EXPECTED (video.currentTime < 'video.duration') OK
+
+++ Pausing now that test is over to prevent additional unwanted looping.
+RUN(video.pause())
+
+END OF TEST
+
« no previous file with comments | « LayoutTests/media/video-loop-from-ended.html ('k') | Source/core/html/HTMLMediaElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698