Fixes play seek when user sets loop after ended.

Source/core/html/HTMLMediaElement.h

Index: Source/core/html/HTMLMediaElement.h
diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h
index 6f539a0bd30757c50c9e939d57f7547960ee2ceb..b8d04f76a5b2ebbdcc04594dd15788b11cc5e937 100644
--- a/Source/core/html/HTMLMediaElement.h
+++ b/Source/core/html/HTMLMediaElement.h
@@ -412,6 +412,7 @@ private:
     void updatePlayState();
     bool potentiallyPlaying() const;
     bool endedPlayback() const;

[wolenetz, 2015/02/12 22:12:27]

There are only a few calls to this method. I'm not convinced the overload is
justified versus explicitly passing the ignoreLoopAttr.

philipj@: I defer to you on this though.

[chcunningham, 2015/02/13 03:37:29]

For me its less about the convenience, more about the self documenting nature of
the overload. This neatly expresses a default (considering loop) vs special case
(not considering the loop). 

[fs, 2015/02/13 11:49:22]

It's fairly common in Blink to use default arguments for these cases (unlike in
Chromium in general where you wouldn't). Given the documentation/comment in the
zero-arity overload this split might be useful though (even if that seems to
somewhat contradict your statement about "self documenting" =))

[wolenetz, 2015/02/13 22:24:23]

Good points. I would prefer default argument, with more documentation at
endedPlayback() declaration here about what the argument means.

[chcunningham, 2015/02/13 23:01:43]

Acknowledged.

[chcunningham, 2015/02/13 23:01:43]

Done.

+    bool endedPlayback(bool ignoreLoopAttr) const;
     bool stoppedDueToErrors() const;
     bool couldPlayIfEnoughData() const;