Fixes play seek when user sets loop after ended.

Source/core/html/HTMLMediaElement.h

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 393 matching lines @@
     // This does not check user gesture restrictions.
     void playInternal();
 
     void gesturelessInitialPlayHalted();
     void autoplayMediaEncountered();
     void allowVideoRendering();
 
     void updateVolume();
     void updatePlayState();
     bool potentiallyPlaying() const;
     bool endedPlayback() const;

[wolenetz, 2015/02/12 22:12:27]

There are only a few calls to this method. I'm not convinced the overload is
justified versus explicitly passing the ignoreLoopAttr.

philipj@: I defer to you on this though.

[chcunningham, 2015/02/13 03:37:29]

For me its less about the convenience, more about the self documenting nature of
the overload. This neatly expresses a default (considering loop) vs special case
(not considering the loop). 

[fs, 2015/02/13 11:49:22]

It's fairly common in Blink to use default arguments for these cases (unlike in
Chromium in general where you wouldn't). Given the documentation/comment in the
zero-arity overload this split might be useful though (even if that seems to
somewhat contradict your statement about "self documenting" =))

[wolenetz, 2015/02/13 22:24:23]

Good points. I would prefer default argument, with more documentation at
endedPlayback() declaration here about what the argument means.

[chcunningham, 2015/02/13 23:01:43]

Acknowledged.

[chcunningham, 2015/02/13 23:01:43]

Done.

+    bool endedPlayback(bool ignoreLoopAttr) const;
     bool stoppedDueToErrors() const;
     bool couldPlayIfEnoughData() const;
 
     void setShouldDelayLoadEvent(bool);
     void invalidateCachedTime();
     void refreshCachedTime() const;
 
     bool hasMediaControls() const;
     void ensureMediaControls();
     void configureMediaControls();
@@ skipping 186 matching lines @@
 inline bool isHTMLMediaElement(const HTMLElement& element)
 {
     return isHTMLAudioElement(element) || isHTMLVideoElement(element);
 }
 
 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLMediaElement);
 
 } // namespace blink
 
 #endif // HTMLMediaElement_h