Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: src/api.cc

Issue 898763002: Revert of Add WeakMap to v8.h (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | src/factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 0030e09632305085944ccf9bc3056dbd2fa1e86a..6caa82a5ea5d907119da06e0f2b35e7ce7794347 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -2246,112 +2246,6 @@
bool StackFrame::IsConstructor() const {
return getBoolProperty(this, "isConstructor");
-}
-
-
-// --- W e a k M a p ---
-
-WeakMap* WeakMap::New(Isolate* v8_isolate) {
- i::Isolate* isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
- ENTER_V8(isolate);
- i::HandleScope scope(isolate);
- i::Handle<i::JSWeakMap> weakmap = isolate->factory()->NewJSWeakMap();
- i::Runtime::WeakCollectionInitialize(isolate, weakmap);
- Local<Object> v8_obj = Utils::ToLocal(i::Handle<i::JSObject>::cast(weakmap));
- return new WeakMap(v8_isolate, v8_obj);
-}
-
-
-void WeakMap::Set(Handle<Value> v8_key, Handle<Value> v8_value) {
- v8::HandleScope handleScope(isolate_);
- Local<Object> map_handle = Local<Object>::New(isolate_, map_);
- i::Isolate* isolate = reinterpret_cast<i::Isolate*>(isolate_);
- ENTER_V8(isolate);
- i::Handle<i::Object> key = Utils::OpenHandle(*v8_key);
- i::Handle<i::Object> value = Utils::OpenHandle(*v8_value);
- i::Handle<i::JSWeakMap> weak_collection =
- i::Handle<i::JSWeakMap>::cast(Utils::OpenHandle(*map_handle));
- if (!key->IsJSReceiver() && !key->IsSymbol()) {
- DCHECK(false);
- return;
- }
- i::Handle<i::ObjectHashTable> table(
- i::ObjectHashTable::cast(weak_collection->table()));
- if (!table->IsKey(*key)) {
- DCHECK(false);
- return;
- }
- i::Runtime::WeakCollectionSet(weak_collection, key, value);
-}
-
-
-Local<Value> WeakMap::Get(Handle<Value> v8_key) {
- v8::EscapableHandleScope handleScope(isolate_);
- Local<Object> map_handle = Local<Object>::New(isolate_, map_);
- i::Isolate* isolate = reinterpret_cast<i::Isolate*>(isolate_);
- ENTER_V8(isolate);
- i::Handle<i::Object> key = Utils::OpenHandle(*v8_key);
- i::Handle<i::JSWeakMap> weak_collection =
- i::Handle<i::JSWeakMap>::cast(Utils::OpenHandle(*map_handle));
- if (!key->IsJSReceiver() && !key->IsSymbol()) {
- DCHECK(false);
- return Undefined(isolate_);
- }
- i::Handle<i::ObjectHashTable> table(
- i::ObjectHashTable::cast(weak_collection->table()));
- if (!table->IsKey(*key)) {
- DCHECK(false);
- return Undefined(isolate_);
- }
- i::Handle<i::Object> lookup(table->Lookup(key), isolate);
- if (lookup->IsTheHole()) return Undefined(isolate_);
- Local<Value> result = Utils::ToLocal(lookup);
- return handleScope.Escape(result);
-}
-
-
-bool WeakMap::Has(Handle<Value> v8_key) {
- v8::HandleScope handleScope(isolate_);
- Local<Object> map_handle = Local<Object>::New(isolate_, map_);
- i::Isolate* isolate = reinterpret_cast<i::Isolate*>(isolate_);
- ENTER_V8(isolate);
- i::Handle<i::Object> key = Utils::OpenHandle(*v8_key);
- i::Handle<i::JSWeakMap> weak_collection =
- i::Handle<i::JSWeakMap>::cast(Utils::OpenHandle(*map_handle));
- if (!key->IsJSReceiver() && !key->IsSymbol()) {
- DCHECK(false);
- return false;
- }
- i::Handle<i::ObjectHashTable> table(
- i::ObjectHashTable::cast(weak_collection->table()));
- if (!table->IsKey(*key)) {
- DCHECK(false);
- return false;
- }
- i::Handle<i::Object> lookup(table->Lookup(key), isolate);
- return !lookup->IsTheHole();
-}
-
-
-bool WeakMap::Delete(Handle<Value> v8_key) {
- v8::HandleScope handleScope(isolate_);
- Local<Object> map_handle = Local<Object>::New(isolate_, map_);
- i::Isolate* isolate = reinterpret_cast<i::Isolate*>(isolate_);
- ENTER_V8(isolate);
- i::Handle<i::Object> key = Utils::OpenHandle(*v8_key);
- i::Handle<i::JSWeakMap> weak_collection =
- i::Handle<i::JSWeakMap>::cast(Utils::OpenHandle(*map_handle));
- if (!key->IsJSReceiver() && !key->IsSymbol()) {
- DCHECK(false);
- return false;
- }
- i::Handle<i::ObjectHashTable> table(
- i::ObjectHashTable::cast(weak_collection->table()));
- if (!table->IsKey(*key)) {
- DCHECK(false);
- return false;
- }
- return i::Runtime::WeakCollectionDelete(weak_collection, key);
}
« no previous file with comments | « include/v8.h ('k') | src/factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698