Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: include/v8.h

Issue 898763002: Revert of Add WeakMap to v8.h (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index d1c476ac3240ca32a0d722e6c9c3f5bfda02efe2..e8ca3df18f28fd7219384d63e951f3607b6c7883 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -1533,31 +1533,6 @@
* \return The corresponding value if successfully parsed.
*/
static Local<Value> Parse(Local<String> json_string);
-};
-
-
-/**
- * A map whose keys are referenced weakly. It is similar to JavaScript WeakMap
- * but can be created without entering a v8::Context and hence shouldn't
- * escape to JavaScript.
- */
-class V8_EXPORT WeakMap {
- public:
- static WeakMap* New(Isolate* isolate);
- void Set(Handle<Value> key, Handle<Value> value);
- Local<Value> Get(Handle<Value> key);
- bool Has(Handle<Value> key);
- bool Delete(Handle<Value> key);
-
- private:
- WeakMap(Isolate* isolate, Handle<Object> weak_map)
- : isolate_(isolate), map_(isolate, weak_map) {}
- Isolate* isolate_;
- UniquePersistent<Object> map_;
-
- // Disallow copying and assigning.
- WeakMap(WeakMap&);
- void operator=(WeakMap&);
};
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698