chrome/browser/extensions/api/app_window/app_window_api.cc - Issue 89873002: Ensure that the OSK on Windows 8 shows up when we tap on an editable field in any WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/app_window/app_window_api.cc

Issue 89873002: Ensure that the OSK on Windows 8 shows up when we tap on an editable field in any WebContents. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | chrome/browser/ui/tab_contents/core_tab_helper.h » ('j') | chrome/browser/ui/tab_contents/core_tab_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/app_window/app_window_api.cc

===================================================================

--- chrome/browser/extensions/api/app_window/app_window_api.cc (revision 237093)

+++ chrome/browser/extensions/api/app_window/app_window_api.cc (working copy)

@@ -36,6 +36,10 @@

#include "ui/aura/window.h"

#endif

+#if defined(OS_WIN)

+#include "chrome/browser/ui/touch_web_contents_observer_win.h"

+#endif

using apps::ShellWindow;

namespace app_window = extensions::api::app_window;

@@ -334,6 +338,10 @@

SetCreateResultFromShellWindow(shell_window, result);

SetResult(result);

+#if defined(OS_WIN)

+ TouchWebContentsObserver::CreateForWebContents(shell_window->web_contents());

+#endif

if (apps::ShellWindowRegistry::Get(GetProfile())

->HadDevToolsAttached(created_view)) {

new DevToolsRestorer(this, created_view);