Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: chrome/browser/ui/tab_contents/core_tab_helper.cc

Issue 89873002: Ensure that the OSK on Windows 8 shows up when we tap on an editable field in any WebContents. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_contents/core_tab_helper.cc
===================================================================
--- chrome/browser/ui/tab_contents/core_tab_helper.cc (revision 237093)
+++ chrome/browser/ui/tab_contents/core_tab_helper.cc (working copy)
@@ -32,7 +32,7 @@
#include "ui/gfx/codec/jpeg_codec.h"
#if defined(OS_WIN)
-#include "base/win/win_util.h"
+#include "chrome/browser/ui/touch_web_contents_observer_win.h"
#endif
using content::WebContents;
@@ -43,6 +43,9 @@
: content::WebContentsObserver(web_contents),
delegate_(NULL),
content_restrictions_(0) {
+#if defined(OS_WIN)
+ TouchWebContentsObserver::CreateForWebContents(web_contents);
jam 2013/11/27 17:17:40 this should be created where CoreTabHelper gets cr
+#endif
}
CoreTabHelper::~CoreTabHelper() {
@@ -195,8 +198,6 @@
bool CoreTabHelper::OnMessageReceived(const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(CoreTabHelper, message)
- IPC_MESSAGE_HANDLER(ChromeViewHostMsg_FocusedNodeTouched,
- OnFocusedNodeTouched)
IPC_MESSAGE_HANDLER(ChromeViewHostMsg_RequestThumbnailForContextNode_ACK,
OnRequestThumbnailForContextNodeACK)
IPC_MESSAGE_UNHANDLED(handled = false)
@@ -204,16 +205,6 @@
return handled;
}
-void CoreTabHelper::OnFocusedNodeTouched(bool editable) {
-#if defined(OS_WIN) && defined(USE_AURA)
- if (editable) {
- base::win::DisplayVirtualKeyboard();
- } else {
- base::win::DismissVirtualKeyboard();
- }
-#endif // OS_WIN && USE_AURA
-}
-
// Handles the image thumbnail for the context node, composes a image search
// request based on the received thumbnail and opens the request in a new tab.
void CoreTabHelper::OnRequestThumbnailForContextNodeACK(

Powered by Google App Engine
This is Rietveld 408576698