Chromium Code Reviews

Issue 898693002: Subzero: Fix some -Winconsistent-missing-override that clang 3.6 warns about. (Closed)

Created:
5 years, 10 months ago by jvoung (off chromium)
Modified:
5 years, 10 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix some -Winconsistent-missing-override that clang 3.6 warns about. I'd like to bump the *trusted* clang compiler also, since the really old trusted clang compiler seems to crash if we pair old clang with new libcxx. (So the merge will probably have to bump the trusted clang compiler to a newer rev). BUG= https://code.google.com/p/nativeclient/issues/detail?id=4026 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=3ce1a991150c1f1954f542d0d998f6f75e89fbc6

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Stats (+2 lines, -4 lines)
M src/IceInst.h View 1 chunk +1 line, -1 line 0 comments
M src/IceOperand.h View 1 chunk +0 lines, -2 lines 0 comments
M src/IceTargetLoweringX8632.h View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
5 years, 10 months ago (2015-02-03 03:07:30 UTC) #2
Jim Stichnoth
LGTM. How would you bump the clang compiler version? Have the makefile use the clang ...
5 years, 10 months ago (2015-02-03 05:31:19 UTC) #3
jvoung (off chromium)
Thanks -- To update clang, I would update DEPS like https://codereview.chromium.org/886943004/, which updates the script ...
5 years, 10 months ago (2015-02-03 16:17:56 UTC) #4
jvoung (off chromium)
5 years, 10 months ago (2015-02-03 16:27:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3ce1a991150c1f1954f542d0d998f6f75e89fbc6 (presubmit successful).

Powered by Google App Engine