Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: src/IceOperand.h

Issue 898693002: Subzero: Fix some -Winconsistent-missing-override that clang 3.6 warns about. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: review Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/IceInst.h ('k') | src/IceTargetLoweringX8632.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 //===- subzero/src/IceOperand.h - High-level operands -----------*- C++ -*-===// 1 //===- subzero/src/IceOperand.h - High-level operands -----------*- C++ -*-===//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 // 9 //
10 // This file declares the Operand class and its target-independent 10 // This file declares the Operand class and its target-independent
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 // Constant is the abstract base class for constants. All 97 // Constant is the abstract base class for constants. All
98 // constants are allocated from a global arena and are pooled. 98 // constants are allocated from a global arena and are pooled.
99 class Constant : public Operand { 99 class Constant : public Operand {
100 Constant(const Constant &) = delete; 100 Constant(const Constant &) = delete;
101 Constant &operator=(const Constant &) = delete; 101 Constant &operator=(const Constant &) = delete;
102 102
103 public: 103 public:
104 void emitPoolLabel(Ostream &Str) const { 104 void emitPoolLabel(Ostream &Str) const {
105 Str << ".L$" << getType() << "$" << PoolEntryID; 105 Str << ".L$" << getType() << "$" << PoolEntryID;
106 } 106 }
107 using Operand::dump;
108 void emit(const Cfg *Func) const override { emit(Func->getContext()); } 107 void emit(const Cfg *Func) const override { emit(Func->getContext()); }
109 virtual void emit(GlobalContext *Ctx) const = 0; 108 virtual void emit(GlobalContext *Ctx) const = 0;
110 void dump(const Cfg *Func, Ostream &Str) const = 0;
111 109
112 static bool classof(const Operand *Operand) { 110 static bool classof(const Operand *Operand) {
113 OperandKind Kind = Operand->getKind(); 111 OperandKind Kind = Operand->getKind();
114 return Kind >= kConst_Base && Kind <= kConst_Num; 112 return Kind >= kConst_Base && Kind <= kConst_Num;
115 } 113 }
116 114
117 protected: 115 protected:
118 Constant(OperandKind Kind, Type Ty, uint32_t PoolEntryID) 116 Constant(OperandKind Kind, Type Ty, uint32_t PoolEntryID)
119 : Operand(Kind, Ty), PoolEntryID(PoolEntryID) { 117 : Operand(Kind, Ty), PoolEntryID(PoolEntryID) {
120 Vars = nullptr; 118 Vars = nullptr;
(...skipping 502 matching lines...) Expand 10 before | Expand all | Expand 10 after
623 private: 621 private:
624 const Cfg *Func; 622 const Cfg *Func;
625 MetadataKind Kind; 623 MetadataKind Kind;
626 std::vector<VariableTracking> Metadata; 624 std::vector<VariableTracking> Metadata;
627 const static InstDefList NoDefinitions; 625 const static InstDefList NoDefinitions;
628 }; 626 };
629 627
630 } // end of namespace Ice 628 } // end of namespace Ice
631 629
632 #endif // SUBZERO_SRC_ICEOPERAND_H 630 #endif // SUBZERO_SRC_ICEOPERAND_H
OLDNEW
« no previous file with comments | « src/IceInst.h ('k') | src/IceTargetLoweringX8632.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698