content/browser/service_worker/service_worker_version.cc - Issue 898613004: Sanitize referrers before we create them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 898613004: Sanitize referrers before we create them (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_version.cc

diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc

index 198a02dc76fd9eda28070fecb227b64b620fac9a..4da0c87085a4d50d6b5e0d8603ae7c82fa457652 100644

--- a/content/browser/service_worker/service_worker_version.cc

+++ b/content/browser/service_worker/service_worker_version.cc

@@ -244,11 +244,11 @@ void OpenWindowOnUI(

return;

}

- OpenURLParams params(url,

- Referrer(script_url, blink::WebReferrerPolicyDefault),

- NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_AUTO_TOPLEVEL,

- true /* is_renderer_initiated */);

+ OpenURLParams params(

+ url, Referrer::SanitizeForRequest(

+ url, Referrer(script_url, blink::WebReferrerPolicyDefault)),

+ NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_AUTO_TOPLEVEL,

+ true /* is_renderer_initiated */);

WebContents* web_contents =

GetContentClient()->browser()->OpenURL(browser_context, params);