Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1661)

Unified Diff: chrome/browser/extensions/extension_web_ui.cc

Issue 898613004: Sanitize referrers before we create them (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_inline_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_web_ui.cc
diff --git a/chrome/browser/extensions/extension_web_ui.cc b/chrome/browser/extensions/extension_web_ui.cc
index 166b8a81cb7d325753e21dffb09770cebf15eeef..304875698d93e8f5242a3440676cca08f7d1c1ca 100644
--- a/chrome/browser/extensions/extension_web_ui.cc
+++ b/chrome/browser/extensions/extension_web_ui.cc
@@ -80,7 +80,8 @@ void UnregisterAndReplaceOverrideForWebContents(const std::string& page,
// Don't use Reload() since |url| isn't the same as the internal URL that
// NavigationController has.
web_contents->GetController().LoadURL(
- url, content::Referrer(url, blink::WebReferrerPolicyDefault),
+ url, content::Referrer::SanitizeForRequest(
Mike West 2015/02/09 11:07:38 Nit: Might be worth creating a static helper that
jochen (gone - plz use gerrit) 2015/02/09 12:00:02 dunno, I'd be surprised if the Referrer ctor is no
+ url, content::Referrer(url, blink::WebReferrerPolicyDefault)),
ui::PAGE_TRANSITION_RELOAD, std::string());
}
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_inline_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698