chrome/browser/ui/extensions/application_launch.cc - Issue 898613004: Sanitize referrers before we create them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/application_launch.cc

Issue 898613004: Sanitize referrers before we create them (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/extensions/application_launch.cc

diff --git a/chrome/browser/ui/extensions/application_launch.cc b/chrome/browser/ui/extensions/application_launch.cc

index 931fc0f39de293ec59c51f0478f3f240e5dceb67..996d3ff483116f5f8b1fe11f8b48db20294c78d6 100644

--- a/chrome/browser/ui/extensions/application_launch.cc

+++ b/chrome/browser/ui/extensions/application_launch.cc

@@ -262,10 +262,10 @@ WebContents* OpenApplicationTab(const AppLaunchParams& launch_params,

int tab_index = model->GetIndexOfWebContents(existing_tab);

existing_tab->OpenURL(content::OpenURLParams(

- url,

- content::Referrer(existing_tab->GetURL(),

- blink::WebReferrerPolicyDefault),

- disposition, ui::PAGE_TRANSITION_LINK, false));

+ url, content::Referrer::SanitizeForRequest(

+ url, content::Referrer(existing_tab->GetURL(),

+ blink::WebReferrerPolicyDefault)),

+ disposition, ui::PAGE_TRANSITION_LINK, false));

// Reset existing_tab as OpenURL() may have clobbered it.

existing_tab = browser->tab_strip_model()->GetActiveWebContents();

if (params.tabstrip_add_types & TabStripModel::ADD_PINNED) {