chrome/browser/extensions/webstore_installer.cc - Issue 898613004: Sanitize referrers before we create them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 898613004: Sanitize referrers before we create them (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_installer.cc

diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc

index 592a915292bdd62eb9a33e3cd3c8dd6e30d1d2b8..45d075d93328c8f1ba76ccca9d7db03dd06b8ad2 100644

--- a/chrome/browser/extensions/webstore_installer.cc

+++ b/chrome/browser/extensions/webstore_installer.cc

@@ -649,9 +649,9 @@ void WebstoreInstaller::StartDownload(const std::string& extension_id,

resource_context));

params->set_file_path(file);

if (controller.GetVisibleEntry())

- params->set_referrer(

- content::Referrer(controller.GetVisibleEntry()->GetURL(),

- blink::WebReferrerPolicyDefault));

+ params->set_referrer(content::Referrer::SanitizeForRequest(

+ download_url_, content::Referrer(controller.GetVisibleEntry()->GetURL(),

+ blink::WebReferrerPolicyDefault)));

params->set_callback(base::Bind(&WebstoreInstaller::OnDownloadStarted,

this,

extension_id));